Skip to content

[HttpFoundation] Document all core response http control directives #13500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
Apr 6, 2020
Merged

[HttpFoundation] Document all core response http control directives #13500

javiereguiluz merged 1 commit into from
Apr 6, 2020

Conversation

@osavchenko
Copy link
Contributor

@osavchenko osavchenko commented Apr 6, 2020

Resolve #13496.

@javiereguiluz javiereguiluz added this to the 5.1 milestone Apr 6, 2020
@javiereguiluz javiereguiluz merged commit c49560c into symfony:master Apr 6, 2020
@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 6, 2020

Thanks Oleksandr! Your pull request was great, but it lacked a minor detail: the versionadded directive, which we added them in 0a83616.

@osavchenko osavchenko deleted the document_all_core_response_http_control_directives branch April 6, 2020 13:42
@osavchenko
Copy link
Contributor Author

osavchenko commented Apr 6, 2020

Thank you for the notice! I will keep in mind for future pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

HttpFoundation Status: Reviewed

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

[HttpFoundation] Add support for all core response http control directi…

3 participants

@osavchenko @javiereguiluz @carsonbot