[setup] Friendlier phrasing for people choosing not to use the Symfony CLI #13461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobdenotter
changed the title
wouterj
approved these changes
Mar 31, 2020
Member
wouterj
left a comment
wouterj
left a comment
There was a problem hiding this comment.
I agree with the rewording. It's saying the same, but with less words and less passive judgement.
dbrumann
approved these changes
Mar 31, 2020
Member
|
Thank you Bob. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Apr 1, 2020
…t (wouterj) This PR was merged into the 4.4 branch. Discussion ---------- No longer list the Symfony binary as a requirement Based on the same Slack discussion as symfony#13461, I think we should also change this section a little bit. Instead of listing it as a requirement (and then in the next sections, mention ways to do things without Symfony CLI), I think it's more fair to mention it as a highly recommended tool instead. Commits ------- dfe0cf8 No longer list the Symfony binary as a requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in a discussion on Slack, after the thread on Reddit about the Symfony CLI. This PR changes the phrase "If you can't or don't want to install Symfony for any reason" to wording that sounds less, perhaps, judging.
Personally I like using the Symfony CLI, but not everybody does. And since it's by no means required to do so, we shouldn't assume the reason why other people might choose not to. ^_^