Skip to content

Conversation

@HypeMC
Copy link
Member

@HypeMC HypeMC commented Mar 2, 2020

The secret environment variable processor was removed in symfony/symfony#34295, yet the examples in the docs still use it. The text in the docs seems to have been updated in 75e5ae6 & is ok, it's just these examples that are still wrong.

@OskarStark
Copy link
Contributor

This change looks valid to me. @weaverryan as you reworded the text in the mentioned commit, can you please take a look? Thanks

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javiereguiluz
Copy link
Member

Thanks @HypeMC.

@javiereguiluz javiereguiluz merged commit c672a84 into symfony:4.4 Mar 5, 2020
@HypeMC HypeMC deleted the remove-references-to-secret-env-processors branch March 5, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants