Skip to content

[Notifier] Document sinch transport dsn #13215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
Feb 22, 2020
Merged

[Notifier] Document sinch transport dsn #13215

javiereguiluz merged 1 commit into from
Feb 22, 2020

Conversation

@jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Feb 22, 2020 •
edited by javiereguiluz
Loading

Fixes #13165

wouterj
wouterj approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@javiereguiluz javiereguiluz added this to the 5.1 milestone Feb 22, 2020
@javiereguiluz javiereguiluz merged commit 4b8aa8e into symfony:master Feb 22, 2020
@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 22, 2020

Thanks Jan! Your contribution was great, but the versionadded directive had to be updated too to mention that this was added in 5.1. We did that while merging. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wouterj wouterj wouterj approved these changes

+1 more reviewer

@dbrumann dbrumann dbrumann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Notifier Status: Reviewed

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

[Notifier] added Sinch texter transport

5 participants

@jschaedl @javiereguiluz @wouterj @dbrumann @carsonbot