[Messenger] update events for 4.4 #12586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Nov 4, 2019
dbrumann
approved these changes
Nov 4, 2019
Contributor
dbrumann
left a comment
dbrumann
left a comment
There was a problem hiding this comment.
Just a minor nitpick, but I would prefer if these where ordered alphabetically.
Contributor
Author
|
I think listing them by the order they are dispatched is more readable and logical. |
OskarStark
approved these changes
Nov 6, 2019
Member
|
Thanks! I agree with ordering them in the order they are dispatched. |
wouterj
added a commit
that referenced
this pull request
Nov 9, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] update events for 4.4 Documentation for symfony/symfony#34217 Commits ------- 3374261 [Messenger] update events for 4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for symfony/symfony#34217