Documented $response->getInfo('canceled') #12526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 21, 2019
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
(after minor typo is fixed)
components/http_client.rst
Outdated
| and will abort the request. | ||
|
|
||
| In case the response was canceled using ``$response->cancel()``, | ||
| ``$response->getInfo('canceled')`` will return `true`. |
Member
There was a problem hiding this comment.
double backticks around true
Contributor
Author
|
Fixed, sorry. |
OskarStark
approved these changes
Oct 21, 2019
Member
|
@OskarStark note for mergers: we must add |
OskarStark
force-pushed
the
response-canceled-info
branch
from
f366d19 to
71cff04
Compare
Contributor
|
Thank you Yanick. |
OskarStark
added a commit
that referenced
this pull request
Oct 23, 2019
This PR was squashed before being merged into the 4.4 branch (closes #12526). Discussion ---------- Documented $response->getInfo('canceled') Documented the new `canceled` information introduced in symfony/symfony#34044. Reading the docs, I wonder if we need to catch any `Throwable` and also set `canceled` to `true` @nicolas-grekas? Commits ------- 71cff04 Documented $response->getInfo('canceled')
Contributor
|
I added the missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented the new
canceledinformation introduced in symfony/symfony#34044.Reading the docs, I wonder if we need to catch any
Throwableand also setcanceledtotrue@nicolas-grekas?