Document Twig test "rootform" #10022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is better now, gracias Javier 👍 |
yceruto
commented
Jul 5, 2018
reference/forms/twig_reference.rst
Outdated
|
|
||
| .. code-block:: twig | ||
| {# DON'T DO THIS: this code will fail when the form doesn't have a parent |
Member
Author
There was a problem hiding this comment.
I'd like to rephrase this sentence... since in no case this code will fail because the FormView has a public parent property. The problem appears when you have also defined a parent form field. The last one will have priority for Twig due the array access ability.
I'm not sure how to explain it in short though.
Member
Author
There was a problem hiding this comment.
I mean... what you expect for form.parent could change depending on whether your form has or not a parent field. If no: you're checking the parent view, if yes: you're checking the parent field
Member
Author
|
Perfect, thank you! |
Member
|
Yonel, thanks for implementing this feature and for providing the docs for it! |
HeahDude
reviewed
Jul 6, 2018
| .. code-block:: twig | ||
| {# DON'T DO THIS: this simple check can't differentiate between a form having | ||
| a parent form view and a form defining a normal form field called 'parent' #} |
xabbuh
added a commit
that referenced
this pull request
Aug 7, 2018
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 8, 2018
* 3.4: Simplified the "Release Process" page [Workflow] Fix typo documentation Fix mismatched list items [symfony#9988] fix minor typos [symfony#10099] update XML and PHP config examples [symfony#9969] fix a minor typo [symfony#10022] fix a minor typo preUpdate Event Listener On Uploaded Imagery [symfony#10124] fix XML attribute name [symfony#10062] fix the code block [PHPUnitBridge] Explain how to show stack traces Fix docs on trusted hosts opcode optimizations
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 8, 2018
* 4.1: Simplified the "Release Process" page [Workflow] Fix typo documentation Fix mismatched list items typos in sample code [symfony#9988] fix minor typos [symfony#10099] update XML and PHP config examples [symfony#9969] fix a minor typo [symfony#10022] fix a minor typo preUpdate Event Listener On Uploaded Imagery [symfony#9757] fix rst syntax [symfony#10124] fix XML attribute name [symfony#10062] fix the code block [PHPUnitBridge] Explain how to show stack traces Fix docs on trusted hosts opcode optimizations
Guikingone
pushed a commit
to Guikingone/symfony-docs
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents PR symfony/symfony#25236 and closes #8829, sorry for the delay.