Update Client.php #9762
Closed
Update Client.php #9762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue symfony#9527
Contributor
|
@parapety please update the description to follow the PR template. |
Contributor
|
you can also change the title to |
Member
|
Please add a test covering this bug, to avoid regressions |
cordoval
added a commit
to cordoval/symfony
that referenced
this pull request
Dec 19, 2013
… for overridding server paramters therby documenting correct behavior
Contributor
|
@parapety even though your PR change did not get merge please keep trying to contribute. Your initial help ignited me to get the right fix. All was a team effort /o/, encouragements in all good there in Warszawa. I hope to visit again soon 👶 |
Member
|
closing in favor of #9821 |
This was referenced Dec 30, 2013
fabpot
added a commit
that referenced
this pull request
Mar 27, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Fixed server values in BrowserKit | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9527, #9762, #9821, #9901 | License | MIT | Doc PR | n/a Commits ------- 65b9810 fixed too greedy replacements d9cf28d fixed protocol-relative URLs 289da16 added override power to server parameters provided on request method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #9527