Skip to content

Conversation

@ayyoub-afwallah
Copy link
Contributor

@ayyoub-afwallah ayyoub-afwallah commented Dec 19, 2025

Q A
Branch? 8.1
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix -
License MIT

As suggested by @stof in #62341 (comment)

This PR allows #[AsTaggedItem] to set priority on voters

Unlike #[AutoconfigureTag] or YAML config, #[AsTaggedItem] doesn't create duplicate tags and doesn't require specifying a tag name.

#[AsTaggedItem(priority: 10)]
final class PostVoter extends Voter

Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry in the SecurityBundle changelog.

@OskarStark OskarStark changed the title [DependencyInjection][SecurityBundle] Leverage AsTaggedItem for voters [DependencyInjection][SecurityBundle] Leverage #[AsTaggedItem] for voters Dec 19, 2025
@ayyoub-afwallah ayyoub-afwallah force-pushed the feature/leverage-astaggeditem-for-voters branch 2 times, most recently from 49253af to 7ab6483 Compare December 19, 2025 11:13
@ayyoub-afwallah
Copy link
Contributor Author

Please add a changelog entry in the SecurityBundle changelog.

Done :)

@ayyoub-afwallah ayyoub-afwallah force-pushed the feature/leverage-astaggeditem-for-voters branch from 7ab6483 to 2e5666c Compare December 19, 2025 20:14
@fabpot
Copy link
Member

fabpot commented Dec 21, 2025

Thank you @ayyoub-afwallah.

@fabpot fabpot merged commit 909b819 into symfony:8.1 Dec 21, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants