Skip to content

[Translation] Perf: Keep catalogues if fallback locales have no change #62790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Dec 19, 2025
+6 −0
Merged

[Translation] Perf: Keep catalogues if fallback locales have no change #62790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Symfony/Component/Translation/Translator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,12 @@ public function getLocale(): string
*/
public function setFallbackLocales(array $locales): void
{
if ($this->getFallbackLocales() === $locales) {
// No change in fallback locales:
// Do not clear catalogues as regeneration of catalogues is computational expensive.
Comment on lines +149 to +150
Copy link
Member

@nicolas-grekas nicolas-grekas Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// No change in fallback locales:
// Do not clear catalogues as regeneration of catalogues is computational expensive.

return;
}

// needed as the fallback locales are linked to the already loaded catalogues
$this->catalogues = [];

Expand Down
Loading