Skip to content

[Serializer] Do not skip nested null values when denormalizing #62773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Dec 16, 2025
+32 −7
Merged

[Serializer] Do not skip nested null values when denormalizing #62773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace Symfony\Component\Serializer\Normalizer;

use Symfony\Component\PropertyAccess\Exception\InvalidArgumentException as PropertyAccessInvalidArgumentException;
use Symfony\Component\PropertyAccess\Exception\NoSuchIndexException;
use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
use Symfony\Component\PropertyAccess\Exception\UninitializedPropertyException;
use Symfony\Component\PropertyAccess\PropertyAccess;
Expand Down Expand Up @@ -333,15 +334,16 @@ public function denormalize(mixed $data, string $type, ?string $format = null, a

$nestedAttributes = $this->getNestedAttributes($mappedClass);
$nestedData = $originalNestedData = [];
$propertyAccessor = PropertyAccess::createPropertyAccessor();
$propertyAccessor = PropertyAccess::createPropertyAccessorBuilder()->enableExceptionOnInvalidIndex()->getPropertyAccessor();
foreach ($nestedAttributes as $property => $serializedPath) {
if (null === $value = $propertyAccessor->getValue($normalizedData, $serializedPath)) {
continue;
try {
$value = $propertyAccessor->getValue($normalizedData, $serializedPath);
$convertedProperty = $this->nameConverter ? $this->nameConverter->normalize($property, $mappedClass, $format, $context) : $property;
$nestedData[$convertedProperty] = $value;
$originalNestedData[$property] = $value;
$normalizedData = $this->removeNestedValue($serializedPath->getElements(), $normalizedData);
} catch (NoSuchIndexException) {
}
$convertedProperty = $this->nameConverter ? $this->nameConverter->normalize($property, $mappedClass, $format, $context) : $property;
$nestedData[$convertedProperty] = $value;
$originalNestedData[$property] = $value;
$normalizedData = $this->removeNestedValue($serializedPath->getElements(), $normalizedData);
}

$normalizedData = $nestedData + $normalizedData;
Expand Down
23 changes: 23 additions & 0 deletions src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,6 +850,29 @@ public function testDenormalizeWithCorrectOrderOfAttributeAndProperty()
$this->assertSame('nested-id', $test->id);
}

public function testDenormalizeMissingAndNullNestedValues()
{
$normalizer = new AbstractObjectNormalizerWithMetadata();

$data = [
'data' => [
'foo' => null,
],
];

$obj = new class {
#[SerializedPath('[data][foo]')]
public ?string $foo;

#[SerializedPath('[data][bar]')]
public ?string $bar;
};

$test = $normalizer->denormalize($data, $obj::class);
$this->assertNull($test->foo);
$this->assertFalse((new \ReflectionProperty($obj, 'bar'))->isInitialized($obj));
}

public function testNormalizeBasedOnAllowedAttributes()
{
$normalizer = new class extends AbstractObjectNormalizer {
Expand Down
Loading