Skip to content

[DependencyInjection] Fix PriorityTaggedServiceTrait when tag attributes are not a list #62685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Dec 8, 2025
+16 −0
Merged

[DependencyInjection] Fix PriorityTaggedServiceTrait when tag attributes are not a list #62685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@
$phpAttributes = [];
}

$attributes = array_values($attributes);
for ($i = 0; $i < \count($attributes); ++$i) {
if (!($attribute = $attributes[$i]) && $phpAttributes) {

Check failure on line 86 in src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php

View workflow job for this annotation

GitHub Actions / Psalm

InvalidArrayOffset 

src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php:86:36: InvalidArrayOffset: Cannot access value on variable $attributes using a int<min, 1> offset, expecting int<0, max> (see https://psalm.dev/115)

Check failure on line 86 in src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php

View workflow job for this annotation

GitHub Actions / Psalm

InvalidArrayOffset 

src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php:86:36: InvalidArrayOffset: Cannot access value on variable $attributes using a int<min, 1> offset, expecting int<0, max> (see https://psalm.dev/115)
array_splice($attributes, $i--, 1, $phpAttributes);
continue;
}
Expand Down
15 changes: 15 additions & 0 deletions src/Symfony/Component/DependencyInjection/Tests/Compiler/PriorityTaggedServiceTraitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,21 @@ public function testMultiTagsWithMixedAttributesAndNonStaticDefault()
$this->assertArrayHasKey('foo', $services);
$this->assertArrayHasKey('default', $services);
}

public function testTagAttributesAreNotAList()
{
$container = new ContainerBuilder();
$container->register('service1')->setTags([
'my_custom_tag' => [1 => ['attributes' => 'not_a_list']],
]);

$priorityTaggedServiceTraitImplementation = new PriorityTaggedServiceTraitImplementation();

$expected = [
new Reference('service1'),
];
$this->assertEquals($expected, $priorityTaggedServiceTraitImplementation->test('my_custom_tag', $container));
}
}

class PriorityTaggedServiceTraitImplementation
Expand Down
Loading