Skip to content

[Runtime] Reuse the already created Request object when the app needs one as argument and returns a kernel #62661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Dec 5, 2025
Merged

[Runtime] Reuse the already created Request object when the app needs one as argument and returns a kernel #62661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Symfony/Component/Runtime/SymfonyRuntime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
private readonly ConsoleOutput $output;
private readonly Application $console;
private readonly Command $command;
private readonly Request $request;

/**
* @param array {
Expand Down Expand Up @@ -131,7 +132,7 @@
public function getRunner(?object $application): RunnerInterface
{
if ($application instanceof HttpKernelInterface) {
return new HttpKernelRunner($application, Request::createFromGlobals(), $this->options['debug'] ?? false);
return new HttpKernelRunner($application, $this->request ??= Request::createFromGlobals(), $this->options['debug'] ?? false);

Check failure on line 135 in src/Symfony/Component/Runtime/SymfonyRuntime.php

View workflow job for this annotation

GitHub Actions / Psalm

InaccessibleProperty 

src/Symfony/Component/Runtime/SymfonyRuntime.php:135:55: InaccessibleProperty: Symfony\Component\Runtime\SymfonyRuntime::$request is marked readonly (see https://psalm.dev/054)

Check failure on line 135 in src/Symfony/Component/Runtime/SymfonyRuntime.php

View workflow job for this annotation

GitHub Actions / Psalm

InaccessibleProperty 

src/Symfony/Component/Runtime/SymfonyRuntime.php:135:55: InaccessibleProperty: Symfony\Component\Runtime\SymfonyRuntime::$request is marked readonly (see https://psalm.dev/054)
}

if ($application instanceof Response) {
Expand Down Expand Up @@ -179,7 +180,7 @@
protected function getArgument(\ReflectionParameter $parameter, ?string $type): mixed
{
return match ($type) {
Request::class => Request::createFromGlobals(),
Request::class => $this->request ??= Request::createFromGlobals(),

Check failure on line 183 in src/Symfony/Component/Runtime/SymfonyRuntime.php

View workflow job for this annotation

GitHub Actions / Psalm

InaccessibleProperty 

src/Symfony/Component/Runtime/SymfonyRuntime.php:183:31: InaccessibleProperty: Symfony\Component\Runtime\SymfonyRuntime::$request is marked readonly (see https://psalm.dev/054)

Check failure on line 183 in src/Symfony/Component/Runtime/SymfonyRuntime.php

View workflow job for this annotation

GitHub Actions / Psalm

InaccessibleProperty 

src/Symfony/Component/Runtime/SymfonyRuntime.php:183:31: InaccessibleProperty: Symfony\Component\Runtime\SymfonyRuntime::$request is marked readonly (see https://psalm.dev/054)
InputInterface::class => $this->getInput(),
OutputInterface::class => $this->output ??= new ConsoleOutput(),
Application::class => $this->console ??= new Application(),
Expand Down
Loading