Skip to content

[Console] don't discard existing aliases when constructing Command #62562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalasr merged 1 commit into from
Dec 2, 2025
+20 −1
Merged

[Console] don't discard existing aliases when constructing Command #62562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Symfony/Component/Console/Command/Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,12 @@ public function __construct(?string $name = null, ?callable $code = null)
$name = array_shift($aliases);
}

// we must not overwrite existing aliases, combine new ones with existing ones
$aliases = array_unique([
...$this->aliases,
...$aliases,
]);

$this->setAliases($aliases);
}

Expand Down
15 changes: 14 additions & 1 deletion src/Symfony/Component/Console/Tests/Command/CommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,25 @@ public function testGetProcessedHelp()
public function testGetSetAliases()
{
$command = new \TestCommand();
$this->assertEquals(['name'], $command->getAliases(), '->getAliases() returns the aliases');
$ret = $command->setAliases(['name1']);
$this->assertEquals($command, $ret, '->setAliases() implements a fluent interface');
$this->assertEquals(['name1'], $command->getAliases(), '->setAliases() sets the aliases');
}

public function testAliasesSetBeforeParentConstructorArePreserved()
{
$command = new class extends Command {
public function __construct()
{
// set aliases before calling parent constructor
$this->setAliases(['existingalias']);
parent::__construct('foo|newalias');
}
};

$this->assertSame(['existingalias', 'newalias'], $command->getAliases(), 'Aliases set before parent::__construct() must be preserved.');
}

#[TestWith(['name|alias1|alias2', 'name', ['alias1', 'alias2'], false])]
#[TestWith(['|alias1|alias2', 'alias1', ['alias2'], true])]
public function testSetAliasesAndHiddenViaName(string $name, string $expectedName, array $expectedAliases, bool $expectedHidden)
Expand Down