Skip to content

Conversation

@tillkruss
Copy link
Contributor

@tillkruss tillkruss commented Nov 24, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues #59846
License MIT

This test was disabled and should not longer segfault.

@carsonbot carsonbot added this to the 8.1 milestone Nov 24, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 8.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Restore Relay 8.5 test Restore Relay 8.5 test Nov 24, 2025
@xabbuh xabbuh modified the milestones: 8.1, 6.4 Nov 25, 2025
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the heads up 👍

@fabpot fabpot changed the base branch from 8.1 to 6.4 November 25, 2025 07:33
@fabpot fabpot changed the base branch from 6.4 to 8.1 November 25, 2025 07:33
@fabpot fabpot changed the base branch from 8.1 to 6.4 November 25, 2025 07:35
@fabpot fabpot changed the base branch from 6.4 to 8.1 November 25, 2025 07:35
@stof
Copy link
Member

stof commented Nov 25, 2025

the link in the issue description is a 404. Is this a link pointing to a private repository ?

@tillkruss
Copy link
Contributor Author

the link in the issue description is a 404. Is this a link pointing to a private repository ?

Sorry, I fixed the link.

@stof
Copy link
Member

stof commented Nov 26, 2025

this should be done in an older branch than 8.1 IMO.

@xabbuh xabbuh changed the base branch from 8.1 to 6.4 November 26, 2025 15:51
@xabbuh
Copy link
Member

xabbuh commented Nov 26, 2025

Thank you @tillkruss.

@xabbuh xabbuh merged commit ea7eb35 into symfony:6.4 Nov 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants