Skip to content

[Security] Fix UserBadge validation bypass via identifier normalizer #62487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Nov 24, 2025
+38 −7
Merged

[Security] Fix UserBadge validation bypass via identifier normalizer #62487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/Symfony/Component/Security/Http/Authenticator/Passport/Badge/UserBadge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,8 @@ public function __construct(
private ?array $attributes = null,
?\Closure $identifierNormalizer = null,
) {
if ('' === $userIdentifier) {
trigger_deprecation('symfony/security-http', '7.2', 'Using an empty string as user identifier is deprecated and will throw an exception in Symfony 8.0.');
// throw new BadCredentialsException('Empty user identifier.');
}
$this->validateUserIdentifier($userIdentifier);

if (\strlen($userIdentifier) > self::MAX_USERNAME_LENGTH) {
throw new BadCredentialsException('Username too long.');
}
if ($identifierNormalizer) {
$this->identifierNormalizer = static fn () => $identifierNormalizer($userIdentifier);
}
Expand All @@ -74,6 +68,8 @@ public function getUserIdentifier(): string
if (isset($this->identifierNormalizer)) {
$this->userIdentifier = ($this->identifierNormalizer)();
$this->identifierNormalizer = null;

$this->validateUserIdentifier($this->userIdentifier);
}

return $this->userIdentifier;
Expand Down Expand Up @@ -132,4 +128,16 @@ public function isResolved(): bool
{
return true;
}

private function validateUserIdentifier(string $userIdentifier): void
{
if ('' === $userIdentifier) {
trigger_deprecation('symfony/security-http', '7.2', 'Using an empty string as user identifier is deprecated and will throw an exception in Symfony 8.0.');
// throw new BadCredentialsException('Empty user identifier.');
}

if (\strlen($userIdentifier) > self::MAX_USERNAME_LENGTH) {
throw new BadCredentialsException('Username too long.');
}
}
}
23 changes: 23 additions & 0 deletions src/Symfony/Component/Security/Http/Tests/Authenticator/Passport/Badge/UserBadgeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

use PHPUnit\Framework\TestCase;
use Symfony\Bridge\PhpUnit\ExpectUserDeprecationMessageTrait;
use Symfony\Component\Security\Core\Exception\BadCredentialsException;
use Symfony\Component\Security\Core\Exception\UserNotFoundException;
use Symfony\Component\Security\Http\Authenticator\Passport\Badge\UserBadge;
use Symfony\Component\String\Slugger\AsciiSlugger;
Expand Down Expand Up @@ -69,4 +70,26 @@ public static function provideUserIdentifierNormalizationData(): iterable
yield 'Greek to ASCII' => ['ΝιΚόΛΑος', 'NIKOLAOS', $upperAndAscii];
yield 'Katakana to ASCII' => ['たなかそういち', 'TANAKASOUICHI', $upperAndAscii];
}

/**
* @group legacy
*/
public function testUserIdentifierNormalizationTriggersDeprecationForEmptyString()
{
$badge = new UserBadge('valid_input', null, null, fn () => '');

$this->expectUserDeprecationMessage('Since symfony/security-http 7.2: Using an empty string as user identifier is deprecated and will throw an exception in Symfony 8.0.');

$this->assertSame('', $badge->getUserIdentifier());
}

public function testUserIdentifierNormalizationEnforcesMaxLength()
{
$badge = new UserBadge('valid_input', null, null, fn () => str_repeat('a', UserBadge::MAX_USERNAME_LENGTH + 1));

$this->expectException(BadCredentialsException::class);
$this->expectExceptionMessage('Username too long.');

$badge->getUserIdentifier();
}
}