Skip to content

[DependencyInjection] Fix loose validation in #[Autowire] attribute #62482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
Nov 29, 2025
+21 −1
Merged

[DependencyInjection] Fix loose validation in #[Autowire] attribute #62482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/DependencyInjection/Attribute/Autowire.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function __construct(
if (null !== $value && null !== $service) {
throw new LogicException('#[Autowire] attribute cannot declare $value and $service at the same time.');
}
} elseif (!(null !== $value xor null !== $service xor null !== $expression xor null !== $env xor null !== $param)) {
} elseif (1 !== (null !== $value) + (null !== $service) + (null !== $expression) + (null !== $env) + (null !== $param)) {
throw new LogicException('#[Autowire] attribute must declare exactly one of $service, $expression, $env, $param or $value.');
}

Expand Down
20 changes: 20 additions & 0 deletions src/Symfony/Component/DependencyInjection/Tests/Attribute/AutowireTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,24 @@ public static function provideMultipleParameters(): iterable

yield [['value' => 'some-value', 'expression' => 'expr']];
}

/**
* @dataProvider provideMutuallyExclusiveOptions
*/
public function testConstructThrowsOnMutuallyExclusiveOptions(array $parameters)
{
$this->expectException(LogicException::class);
$this->expectExceptionMessage('#[Autowire] attribute must declare exactly one of $service, $expression, $env, $param or $value.');

new Autowire(...$parameters);
}

public static function provideMutuallyExclusiveOptions(): iterable
{
yield [[]];
yield [['value' => 'some-value', 'service' => 'id']];
yield [['value' => 'some-value', 'service' => 'id', 'expression' => 'expr']];
yield [['value' => 'some-value', 'service' => 'id', 'expression' => 'expr', 'env' => 'ENV']];
yield [['value' => 'some-value', 'service' => 'id', 'expression' => 'expr', 'env' => 'ENV', 'param' => 'param']];
}
}