Skip to content

[AssetMapper] Fix entrypoint status lost during update #62456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Nov 21, 2025
Merged

[AssetMapper] Fix entrypoint status lost during update #62456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Symfony/Component/AssetMapper/ImportMap/ImportMapManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ private function updateImportMapConfig(bool $update, array $packagesToRequire, a
$entry->packageModuleSpecifier,
null,
$importName,
null,
$entry->isEntrypoint,
);

// remove it: then it will be re-added
Expand Down
36 changes: 32 additions & 4 deletions src/Symfony/Component/AssetMapper/Tests/ImportMap/ImportMapManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,34 @@ public static function getPackageNameTests(): iterable
];
}

public function testUpdatePreservesEntrypointStatus()
{
$manager = $this->createImportMapManager();

$this->mockImportMap([
self::createRemoteEntry('my_entrypoint', version: '1.0.0', isEntrypoint: true),
self::createRemoteEntry('standard_lib', version: '2.0.0', isEntrypoint: false),
]);

$this->packageResolver->expects($this->once())
->method('resolvePackages')
->willReturn([
self::resolvedPackage('my_entrypoint', '1.0.1', isEntrypoint: true),
self::resolvedPackage('standard_lib', '2.1.0'),
]);

$this->configReader->expects($this->once())
->method('writeEntries')
->with($this->callback(function (ImportMapEntries $entries) {
$this->assertTrue($entries->get('my_entrypoint')->isEntrypoint, 'Entrypoint status lost!');
$this->assertFalse($entries->get('standard_lib')->isEntrypoint);

return true;
}));

$manager->update();
}

private function createImportMapManager(): ImportMapManager
{
$this->assetMapper = $this->createMock(AssetMapperInterface::class);
Expand All @@ -390,10 +418,10 @@ private function createImportMapManager(): ImportMapManager
);
}

private static function resolvedPackage(string $packageName, string $version, ImportMapType $type = ImportMapType::JS)
private static function resolvedPackage(string $packageName, string $version, ImportMapType $type = ImportMapType::JS, bool $isEntrypoint = false)
{
return new ResolvedImportMapPackage(
new PackageRequireOptions($packageName),
new PackageRequireOptions($packageName, entrypoint: $isEntrypoint),
$version,
$type,
);
Expand Down Expand Up @@ -421,11 +449,11 @@ private static function createLocalEntry(string $importName, string $path, Impor
return ImportMapEntry::createLocal($importName, $type, path: $path, isEntrypoint: $isEntrypoint);
}

private static function createRemoteEntry(string $importName, string $version, ?string $path = null, ImportMapType $type = ImportMapType::JS, ?string $packageSpecifier = null): ImportMapEntry
private static function createRemoteEntry(string $importName, string $version, ?string $path = null, ImportMapType $type = ImportMapType::JS, ?string $packageSpecifier = null, bool $isEntrypoint = false): ImportMapEntry
{
$packageSpecifier = $packageSpecifier ?? $importName;
$path = $path ?? '/vendor/any-path.js';

return ImportMapEntry::createRemote($importName, $type, path: $path, version: $version, packageModuleSpecifier: $packageSpecifier, isEntrypoint: false);
return ImportMapEntry::createRemote($importName, $type, path: $path, version: $version, packageModuleSpecifier: $packageSpecifier, isEntrypoint: $isEntrypoint);
}
}
Loading