Skip to content

Conversation

@soyuka
Copy link
Contributor

@soyuka soyuka commented Nov 20, 2025

Q A
Branch? 7.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #62439
License MIT

Property access component supports the dot notation for writing to embedded objects but a line checking reflection was preventing that to work. Its been moved later in the code ensuring that one can write using property accessor's functionalities.

@soyuka soyuka force-pushed the fix/property-access-dot-value branch from d7f95d2 to e748f9e Compare November 20, 2025 16:18
@nicolas-grekas
Copy link
Member

Thank you @soyuka.

@nicolas-grekas nicolas-grekas merged commit a11d7f0 into symfony:7.4 Nov 21, 2025
12 checks passed
This was referenced Nov 21, 2025
@rvanlaak
Copy link
Contributor

@soyuka maybe add symfony/property-accessor to the suggest section as well? https://github.com/symfony/symfony/blob/7.4/src/Symfony/Component/ObjectMapper/composer.json

@soyuka
Copy link
Contributor Author

soyuka commented Nov 25, 2025

@rvanlaak #62508 (comment)

@rvanlaak
Copy link
Contributor

Oh darn, should we throw exceptions when property-accessor features are used but the component isn't available then? Remember having seen such exceptions every now and then, but can't remember the related component. Thanks for tagging!

@stof
Copy link
Member

stof commented Nov 25, 2025

yes, we should if we can do it easily (and without overhead for cases not using those features or using it with PropertyAccessor). This provides much better DX that this suggestion that they won't read at the relevant time.

@soyuka
Copy link
Contributor Author

soyuka commented Nov 25, 2025

most users using the framework bundle will be using property accessor anyways others will probably just take a look at the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants