Skip to content

[FrameworkBundle] work around limitation in JsonResponse when the data is null #62407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Nov 16, 2025
+35 −0
Merged

[FrameworkBundle] work around limitation in JsonResponse when the data is null #62407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Bundle/FrameworkBundle/Controller/AbstractController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,10 @@ protected function json(mixed $data, int $status = 200, array $headers = [], arr
return new JsonResponse($json, $status, $headers, true);
}

if (null === $data) {
return new JsonResponse('null', $status, $headers, true);
}

return new JsonResponse($data, $status, $headers);
}

Expand Down
31 changes: 31 additions & 0 deletions src/Symfony/Bundle/FrameworkBundle/Tests/Controller/AbstractControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,37 @@ public function testJsonWithSerializerContextOverride()
$this->assertEquals('{}', $response->getContent());
}

public function testJsonNull()
{
$controller = $this->createController();
$controller->setContainer(new Container());

$response = $controller->json(null);
$this->assertInstanceOf(JsonResponse::class, $response);
$this->assertSame('null', $response->getContent());
}

public function testJsonNullWithSerializer()
{
$container = new Container();

$serializer = $this->createMock(SerializerInterface::class);
$serializer
->expects($this->once())
->method('serialize')
->with(null, 'json', ['json_encode_options' => JsonResponse::DEFAULT_ENCODING_OPTIONS])
->willReturn('null');

$container->set('serializer', $serializer);

$controller = $this->createController();
$controller->setContainer($container);

$response = $controller->json(null);
$this->assertInstanceOf(JsonResponse::class, $response);
$this->assertSame('null', $response->getContent());
}

public function testFile()
{
$container = new Container();
Expand Down
Loading