Skip to content

[ExpressionLanguage] Compile numbers with var_export in Compiler::repr for thread-safety #62350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Nov 12, 2025
+28 −9
Merged

[ExpressionLanguage] Compile numbers with var_export in Compiler::repr for thread-safety #62350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[ExpressionLanguage] Compile numbers with var_export in Compiler::rep… 
…r for thread-safety
  • Loading branch information
@yoeunes
yoeunes committed Nov 9, 2025
commit 0d1aba8b05f4783a08a97b09569ed751dca7786f
10 changes: 1 addition & 9 deletions src/Symfony/Component/ExpressionLanguage/Compiler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,15 +114,7 @@ public function string(string $value): static
public function repr(mixed $value): static
{
if (\is_int($value) || \is_float($value)) {
if (false !== $locale = setlocale(\LC_NUMERIC, 0)) {
setlocale(\LC_NUMERIC, 'C');
}

$this->raw($value);

if (false !== $locale) {
setlocale(\LC_NUMERIC, $locale);
}
$this->raw(var_export($value, true));
} elseif (null === $value) {
$this->raw('null');
} elseif (\is_bool($value)) {
Expand Down
27 changes: 27 additions & 0 deletions src/Symfony/Component/ExpressionLanguage/Tests/Node/ConstantNodeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,40 @@ public static function getEvaluateData(): array
public static function getCompileData(): array
{
return [
// Booleans
['false', new ConstantNode(false)],
['true', new ConstantNode(true)],

// Null
['null', new ConstantNode(null)],

// Integers
['3', new ConstantNode(3)],
['-10', new ConstantNode(-10)],
['0', new ConstantNode(0)],

// Floats
['3.3', new ConstantNode(3.3)],
['42.0', new ConstantNode(42.0)],
['-1.23', new ConstantNode(-1.23)],
['0.1', new ConstantNode(0.1)],
['1.0', new ConstantNode(1.0)],
['1.0E-6', new ConstantNode(1.0e-6)],
['1.23456789E+20', new ConstantNode(1.23456789e+20)],
['3.3', new ConstantNode(3.2999999999999998)],
['0.30000000000000004', new ConstantNode(0.1 + 0.2)],
['INF', new ConstantNode(\INF)],
['-INF', new ConstantNode(-\INF)],
['NAN', new ConstantNode(\NAN)],

// Strings
['"foo"', new ConstantNode('foo')],
['""', new ConstantNode('')],
['"a\\"b"', new ConstantNode('a"b')],

// Arrays
['[0 => 1, "b" => "a"]', new ConstantNode([1, 'b' => 'a'])],
['[]', new ConstantNode([])],
];
}

Expand Down
Loading