Skip to content

[Clock] Align MockClock::sleep() behavior with NativeClock for negative values #62346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Nov 12, 2025
+14 −0
Merged

[Clock] Align MockClock::sleep() behavior with NativeClock for negative values #62346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Clock] Align MockClock::sleep() behavior with NativeClock for negati… 
…ve values
  • Loading branch information
@yoeunes
yoeunes committed Nov 11, 2025
commit 87ec08d43aa0b26eaba1aa54283c94d81549b0d1
4 changes: 4 additions & 0 deletions src/Symfony/Component/Clock/MockClock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ public function now(): DatePoint

public function sleep(float|int $seconds): void
{
if (0 >= $seconds) {
return;
}

$now = (float) $this->now->format('Uu') + $seconds * 1e6;
$now = substr_replace(\sprintf('@%07.0F', $now), '.', -6, 0);
$timezone = $this->now->getTimezone();
Expand Down
10 changes: 10 additions & 0 deletions src/Symfony/Component/Clock/Tests/MockClockTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,14 @@ public function testWithTimeZone()
$this->assertNotSame($clock, $utcClock);
$this->assertSame('UTC', $utcClock->now()->getTimezone()->getName());
}

public function testSleepWithNegativeValueDoesNothing()
{
$initialTime = new \DateTimeImmutable('2000-01-01 12:00:00 UTC');

$clock = new MockClock($initialTime);
$clock->sleep(-10.5);

$this->assertEquals($initialTime, $clock->now());
}
}
Loading