Skip to content

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 6, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from chalasr as a code owner November 6, 2025 08:05
@carsonbot carsonbot added this to the 6.4 milestone Nov 6, 2025
@carsonbot carsonbot changed the title [Security] add missing Clear-Site-Data directives [Security] add missing Clear-Site-Data directives Nov 6, 2025
@xabbuh
Copy link
Member Author

xabbuh commented Nov 6, 2025

not sure why these directives were not added in #49306, maybe they were added to the documentation afterwards

/cc @maxbeckers

Copy link
Contributor

@maxbeckers maxbeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh might be like that. When I implemented that, i implemented it based on that documentation.

@stof
Copy link
Member

stof commented Nov 6, 2025

Those ones are new experimental features in browsers (see the "experimental" icons in https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Clear-Site-Data#directives).
They have not just been added later in the documentation, but also in the spec.

@xabbuh
Copy link
Member Author

xabbuh commented Nov 6, 2025

We currently already support the executionContexts directive which is also experimental. Though if they were later added to the spec I'd also be fine to add this as a new feature.

@stof
Copy link
Member

stof commented Nov 6, 2025

We currently already support the executionContexts directive which is also experimental.

This one is experimental since more time 😄

@xabbuh xabbuh changed the base branch from 6.4 to 7.4 November 13, 2025 07:48
@xabbuh xabbuh added Feature and removed Bug labels Nov 13, 2025
@xabbuh xabbuh force-pushed the pr-49306 branch 2 times, most recently from 45a5e25 to 8f6980d Compare November 13, 2025 07:51
@xabbuh
Copy link
Member Author

xabbuh commented Nov 13, 2025

rebased and relabeled so that we can merge it once we start the development of 8.1

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.4 Nov 13, 2025
@OskarStark OskarStark changed the title [Security] add missing Clear-Site-Data directives [Security] add missing Clear-Site-Data directives Nov 13, 2025
@nicolas-grekas nicolas-grekas modified the milestones: 7.4, 8.1 Nov 16, 2025
@nicolas-grekas
Copy link
Member

(rebase needed though)

@fabpot
Copy link
Member

fabpot commented Nov 20, 2025

Thank you @xabbuh.

@fabpot fabpot merged commit 0991d0c into symfony:8.1 Nov 20, 2025
8 of 10 checks passed
@xabbuh xabbuh deleted the pr-49306 branch November 20, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants