[HttpClient] Disable HTTP/2 PUSH by default #62279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2025
Member
Author
|
Closing in favor of #62285 |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 3, 2025
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] Reject 3xx pushed responses | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62279 and #62276 | License | MIT I figured out we could reject 3xx pushed responses to fix the linked issues. This makes #62279 unnecessary. Commits ------- ccdf3cb [HttpClient] Reject 3xx pushed responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to disable HTTP/2 PUSH by default on 6.4.
And I propose to remove it altogether from 7.4.
TL;DR, fixing those issues is going to be really difficult and not worth the effort.
If anyone really relies on PUSH, use AmpHttpClient - this one is fine. CurlHttpClient isn't.