[Notifier] Remove unused $transportName argument in EmailChannel::notify() #62262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoeunes
force-pushed
the
notifier-remove-unused-transport-arg
branch
2 times, most recently
from
4231049 to
7a930c6
Compare
nicolas-grekas
force-pushed
the
notifier-remove-unused-transport-arg
branch
from
7a930c6 to
8014c5d
Compare
Member
|
Thank you @yoeunes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a redundant
$transportNameargument passed toEmailMessage::fromNotification()inEmailChannel::notify().This third argument has been ignored since PR #35167.
The transport is already correctly set on the subsequent line (78) via
$message->transport($transportName);, making this argument superfluous. This change simply cleans up the legacy method call.