Fix that kernel share dir is optional now in Framework Configuration #62249
Conversation
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
alexander-schranz
force-pushed
the
bugfix/optional-share-dir
branch
from
bbefa18 to
3bf1126
Compare
alexander-schranz
changed the title
| ->end() | ||
| ->scalarNode('directory')->defaultValue('%kernel.share_dir%/pools/app')->end() | ||
| ->scalarNode('directory')->defaultValue( | ||
| ($this->hasKernelShareDir ? '%kernel.share_dir%' : '%kernel.cache_dir%').'/pools/app' |
|
Hey! Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.4 for features / 6.4, 7.3 for bug fixes". Cheers! Carsonbot |
carsonbot
changed the title
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
👎🏻 The goal is to force setting a different cache driver on distributed servers without shared directory.
This default is for single-server applications (dev) and multi-server applications that can provide a shared directory.
|
I agree with @GromNaN: the failure would be on purpose: once you configure your app with no share dir, you should get a failure if a subsystem is still configured to rely on it. The cache pools is a good example: you don't want the pools to go to the cache dir if there's no share dir. You want to reconfigure the pools to go to redis instead. |
4 participants
The #62248 includes this change, but was not the target of that Pull Request as output is different.
If #62248 merged this can be clsoed.