Skip to content

[DomCrawler] Handle malformed tags in HTML5 parser #62240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Oct 31, 2025
Merged

[DomCrawler] Handle malformed tags in HTML5 parser #62240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Symfony/Component/DomCrawler/Crawler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,11 @@ private function copyFromHtml5ToDom(\Dom\Node $source, \DOMDocument $target): vo
continue;
}

$element = $target->createElement($source->tagName);
try {
$element = $target->createElement($source->tagName);
} catch (\DOMException) {
continue;
}

foreach ($source->attributes as $attr) {
try {
Expand Down
7 changes: 7 additions & 0 deletions src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,6 +1380,13 @@ public static function html5Provider(): iterable
yield 'All together' => [$BOM.' <!--c-->'.$html];
}

public function testHtml5MalformedContent()
{
$crawler = $this->createCrawler();
$crawler->addHtmlContent('<script&>');
self::assertEquals('<head></head><body></body>', $crawler->html());
}

public function testAlpineJs()
{
$crawler = $this->createCrawler();
Expand Down
7 changes: 7 additions & 0 deletions src/Symfony/Component/DomCrawler/Tests/LegacyHtml5ParserCrawlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ public static function invalidHtml5Provider(): iterable
yield 'Text between comments' => ['<!--c--> test <!--cc-->'.$html];
}

public function testHtml5MalformedContent()
{
$crawler = $this->createCrawler();
$crawler->addHtmlContent('<script&>');
self::assertEquals('<head><script></script></head>', $crawler->html());
}

protected function createCrawler($node = null, ?string $uri = null, ?string $baseHref = null)
{
return new Crawler($node, $uri, $baseHref, true);
Expand Down
7 changes: 7 additions & 0 deletions src/Symfony/Component/DomCrawler/Tests/LegacyParserCrawlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,11 @@ public function testAddHtml5()
public function testHtml5ParserParseContentStartingWithValidHeading(string $content)
{
}

public function testHtml5MalformedContent()
{
$crawler = $this->createCrawler();
$crawler->addHtmlContent('<script&>');
self::assertEquals('<head><script></script></head>', $crawler->html());
}
}