[FrameworkBundle] Simplify wiring of scoped clients #62194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
fwb-hc-stack
branch
from
1e9c2eb to
2afc986
Compare
stof
reviewed
Oct 28, 2025
| if ($responseFactoryId = $config['mock_response_factory'] ?? null) { | ||
| $container->register('http_client.mock_client', MockHttpClient::class) | ||
| ->setDecoratedService('http_client.transport', null, -10) // lower priority than TraceableHttpClient (5) | ||
| ->setDecoratedService('http_client.transport', null, -10) // lower priority than ScopingHttpClient (0) |
Member
There was a problem hiding this comment.
Given that this does not decorate the named client, this new comment does not make sense.
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
fwb-hc-stack
branch
from
2afc986 to
eb01ad0
Compare
nicolas-grekas
force-pushed
the
fwb-hc-stack
branch
from
eb01ad0 to
f04c2a8
Compare
stof
approved these changes
Oct 28, 2025
HypeMC
approved these changes
Oct 28, 2025
mtarld
approved these changes
Oct 29, 2025
alexandre-daubois
approved these changes
Oct 29, 2025
Member
|
Thank you @nicolas-grekas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As advised by @stof in #62169 (comment)