Skip to content

[FrameworkBundle] Add missing container.excluded to serializer.attribute_metadata #62185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Oct 28, 2025
Merged

[FrameworkBundle] Add missing container.excluded to serializer.attribute_metadata #62185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1873,13 +1873,13 @@ private function registerValidationConfiguration(array $config, ContainerBuilder
// And when runtime-discovery of attributes is enabled, we can skip compile-time autoconfiguration in debug mode.
if (class_exists(ValidatorAttributeMetadataPass::class) && (!($config['enable_attributes'] ?? false) || !$container->getParameter('kernel.debug')) && trait_exists(ArgumentTrait::class)) {
// The $reflector argument hints at where the attribute could be used
$container->registerAttributeForAutoconfiguration(Constraint::class, function (ChildDefinition $definition, Constraint $attribute, \ReflectionClass|\ReflectionMethod|\ReflectionProperty $reflector) {
$container->registerAttributeForAutoconfiguration(Constraint::class, static function (ChildDefinition $definition, Constraint $attribute, \ReflectionClass|\ReflectionMethod|\ReflectionProperty $reflector) {
$definition->addTag('validator.attribute_metadata')
->addTag('container.excluded', ['source' => 'because it\'s a validator constraint extension']);
});
}

$container->registerAttributeForAutoconfiguration(ExtendsValidationFor::class, function (ChildDefinition $definition, ExtendsValidationFor $attribute) {
$container->registerAttributeForAutoconfiguration(ExtendsValidationFor::class, static function (ChildDefinition $definition, ExtendsValidationFor $attribute) {
$definition->addTag('validator.attribute_metadata', ['for' => $attribute->class])
->addTag('container.excluded', ['source' => 'because it\'s a validator constraint extension']);
});
Expand Down Expand Up @@ -2139,22 +2139,25 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
// And when runtime-discovery of attributes is enabled, we can skip compile-time autoconfiguration in debug mode.
if (class_exists(SerializerAttributeMetadataPass::class) && (!($config['enable_attributes'] ?? false) || !$container->getParameter('kernel.debug'))) {
// The $reflector argument hints at where the attribute could be used
$configurator = function (ChildDefinition $definition, object $attribute, \ReflectionClass|\ReflectionMethod|\ReflectionProperty $reflector) {
$definition->addTag('serializer.attribute_metadata');
$configurator = static function (ChildDefinition $definition, object $attribute, \ReflectionClass|\ReflectionMethod|\ReflectionProperty $reflector) {
$definition->addTag('serializer.attribute_metadata')
->addTag('container.excluded', ['source' => 'because it\'s a serializer metadata extension']);
};
$container->registerAttributeForAutoconfiguration(SerializerMapping\Context::class, $configurator);
$container->registerAttributeForAutoconfiguration(SerializerMapping\Groups::class, $configurator);

$configurator = function (ChildDefinition $definition, object $attribute, \ReflectionMethod|\ReflectionProperty $reflector) {
$definition->addTag('serializer.attribute_metadata');
$configurator = static function (ChildDefinition $definition, object $attribute, \ReflectionMethod|\ReflectionProperty $reflector) {
$definition->addTag('serializer.attribute_metadata')
->addTag('container.excluded', ['source' => 'because it\'s a serializer metadata extension']);
};
$container->registerAttributeForAutoconfiguration(SerializerMapping\Ignore::class, $configurator);
$container->registerAttributeForAutoconfiguration(SerializerMapping\MaxDepth::class, $configurator);
$container->registerAttributeForAutoconfiguration(SerializerMapping\SerializedName::class, $configurator);
$container->registerAttributeForAutoconfiguration(SerializerMapping\SerializedPath::class, $configurator);

$container->registerAttributeForAutoconfiguration(SerializerMapping\DiscriminatorMap::class, function (ChildDefinition $definition) {
$definition->addTag('serializer.attribute_metadata');
$container->registerAttributeForAutoconfiguration(SerializerMapping\DiscriminatorMap::class, static function (ChildDefinition $definition) {
$definition->addTag('serializer.attribute_metadata')
->addTag('container.excluded', ['source' => 'because it\'s a serializer metadata extension']);
});
}

Expand Down Expand Up @@ -2225,7 +2228,7 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder

$container->setParameter('.serializer.named_serializers', $config['named_serializers'] ?? []);

$container->registerAttributeForAutoconfiguration(ExtendsSerializationFor::class, function (ChildDefinition $definition, ExtendsSerializationFor $attribute) {
$container->registerAttributeForAutoconfiguration(ExtendsSerializationFor::class, static function (ChildDefinition $definition, ExtendsSerializationFor $attribute) {
$definition->addTag('serializer.attribute_metadata', ['for' => $attribute->class])
->addTag('container.excluded', ['source' => 'because it\'s a serializer metadata extension']);
});
Expand Down