Skip to content

Clean up legacy groups in tests #62164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
Oct 27, 2025
Merged

Clean up legacy groups in tests #62164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Symfony/Bridge/Twig/Tests/Command/LintCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ public function testLintFileCompileTimeException()
* When deprecations are not reported by the command, the testsuite reporter will catch them so we need to mark the test as ignoring deprecations.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testLintFileWithNotReportedDeprecation()
{
$tester = $this->createCommandTester();
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Bridge/Twig/Tests/Validator/Constraints/TwigValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
namespace Symfony\Bridge\Twig\Tests\Validator\Constraints;

use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use Symfony\Bridge\Twig\Validator\Constraints\Twig;
use Symfony\Bridge\Twig\Validator\Constraints\TwigValidator;
Expand Down Expand Up @@ -68,7 +67,6 @@ public function testInvalidValues($value, $message, $line)
* When deprecations are skipped by the validator, the testsuite reporter will catch them so we need to mark the test as ignoring deprecations.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testTwigWithSkipDeprecation()
{
$constraint = new Twig(skipDeprecations: true);
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Bundle/FrameworkBundle/Tests/Console/Descriptor/AbstractDescriptorTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
namespace Symfony\Bundle\FrameworkBundle\Tests\Console\Descriptor;

use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use PHPUnit\Framework\TestCase;
use Symfony\Bundle\FrameworkBundle\Tests\Fixtures\FooUnitEnum;
Expand Down Expand Up @@ -189,7 +188,6 @@ public static function getDescribeContainerDefinitionWhichIsAnAliasTestData(): a
* The #[IgnoreDeprecation] attribute must be kept as deprecations will always be raised.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
#[DataProvider('getDescribeContainerParameterTestData')]
public function testDescribeContainerParameter($parameter, $expectedDescription, array $options, $file)
{
Expand Down Expand Up @@ -236,7 +234,6 @@ public static function getDescribeCallableTestData(): array
}

#[IgnoreDeprecations]
#[Group('legacy')]
#[DataProvider('getDescribeDeprecatedCallableTestData')]
public function testDescribeDeprecatedCallable($callable, $expectedDescription, $file)
{
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,6 @@ public function testResolveParameter()
}

#[IgnoreDeprecations]
#[Group('legacy')]
public function testOptionalParameter()
{
$container = new ContainerBuilder();
Expand Down
3 changes: 0 additions & 3 deletions ...mfony/Component/DependencyInjection/Tests/Compiler/ResolveReferencesToAliasesPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace Symfony\Component\DependencyInjection\Tests\Compiler;

use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\Alias;
Expand Down Expand Up @@ -88,7 +87,6 @@ public function testResolveFactory()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecationNoticeWhenReferencedByAlias()
{
$this->expectUserDeprecationMessage('Since foobar 1.2.3.4: The "deprecated_foo_alias" service alias is deprecated. You should stop using it, as it will be removed in the future. It is being referenced by the "alias" alias.');
Expand All @@ -110,7 +108,6 @@ public function testDeprecationNoticeWhenReferencedByAlias()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecationNoticeWhenReferencedByDefinition()
{
$this->expectUserDeprecationMessage('Since foobar 1.2.3.4: The "foo_aliased" service alias is deprecated. You should stop using it, as it will be removed in the future. It is being referenced by the "definition" service.');
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ public function testDefinitions()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecateParameter()
{
$builder = new ContainerBuilder();
Expand All @@ -132,7 +131,6 @@ public function testDeprecateParameter()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testParameterDeprecationIsTrgiggeredWhenCompiled()
{
$builder = new ContainerBuilder();
Expand Down Expand Up @@ -2015,7 +2013,6 @@ public function testAutoAliasing()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDirectlyAccessingDeprecatedPublicService()
{
$this->expectUserDeprecationMessage('Since foo/bar 3.8: Accessing the "Symfony\Component\DependencyInjection\Tests\A" service directly from the container is deprecated, use dependency injection instead.');
Expand Down
4 changes: 0 additions & 4 deletions src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

use Bar\FooLazyClass;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use PHPUnit\Framework\Attributes\TestWith;
use PHPUnit\Framework\TestCase;
Expand Down Expand Up @@ -483,7 +482,6 @@ public function testDumpAutowireData()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecatedParameters()
{
$container = include self::$fixturesPath.'/containers/container_deprecated_parameters.php';
Expand All @@ -500,7 +498,6 @@ public function testDeprecatedParameters()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecatedParametersAsFiles()
{
$container = include self::$fixturesPath.'/containers/container_deprecated_parameters.php';
Expand Down Expand Up @@ -1800,7 +1797,6 @@ public function testDumpServiceWithAbstractArgument()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDirectlyAccessingDeprecatedPublicService()
{
$this->expectUserDeprecationMessage('Since foo/bar 3.8: Accessing the "bar" service directly from the container is deprecated, use dependency injection instead.');
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/DependencyInjection/Tests/ParameterBag/FrozenParameterBagTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace Symfony\Component\DependencyInjection\Tests\ParameterBag;

use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ParameterBag\FrozenParameterBag;
Expand Down Expand Up @@ -67,7 +66,6 @@ public function testDeprecate()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testGetDeprecated()
{
$bag = new FrozenParameterBag(
Expand Down
4 changes: 0 additions & 4 deletions src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
namespace Symfony\Component\DependencyInjection\Tests\ParameterBag;

use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use PHPUnit\Framework\Attributes\TestWith;
use PHPUnit\Framework\TestCase;
Expand Down Expand Up @@ -138,7 +137,6 @@ public static function provideGetThrowParameterNotFoundExceptionData()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecate()
{
$bag = new ParameterBag(['foo' => 'bar']);
Expand All @@ -154,7 +152,6 @@ public function testDeprecate()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecateWithMessage()
{
$bag = new ParameterBag(['foo' => 'bar']);
Expand All @@ -170,7 +167,6 @@ public function testDeprecateWithMessage()
* The test must be marked as ignoring deprecations as it always expects a deprecation.
*/
#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecationIsTriggeredWhenResolved()
{
$bag = new ParameterBag(['foo' => '%bar%', 'bar' => 'baz']);
Expand Down
4 changes: 0 additions & 4 deletions src/Symfony/Component/Routing/Tests/Generator/Dumper/CompiledUrlGeneratorDumperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace Symfony\Component\Routing\Tests\Generator\Dumper;

use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Routing\Exception\RouteCircularReferenceException;
Expand Down Expand Up @@ -338,7 +337,6 @@ public function testIndirectCircularReferenceShouldThrowAnException()
}

#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecatedAlias()
{
$this->expectUserDeprecationMessage('Since foo/bar 1.0.0: The "b" route alias is deprecated. You should stop using it, as it will be removed in the future.');
Expand All @@ -355,7 +353,6 @@ public function testDeprecatedAlias()
}

#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecatedAliasWithCustomMessage()
{
$this->expectUserDeprecationMessage('Since foo/bar 1.0.0: foo b.');
Expand All @@ -372,7 +369,6 @@ public function testDeprecatedAliasWithCustomMessage()
}

#[IgnoreDeprecations]
#[Group('legacy')]
public function testTargettingADeprecatedAliasShouldTriggerDeprecation()
{
$this->expectUserDeprecationMessage('Since foo/bar 1.0.0: foo b.');
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,6 @@ public function testAliasWhichTargetRouteDoesntExist()
}

#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecatedAlias()
{
$this->expectUserDeprecationMessage('Since foo/bar 1.0.0: The "b" route alias is deprecated. You should stop using it, as it will be removed in the future.');
Expand All @@ -817,7 +816,6 @@ public function testDeprecatedAlias()
}

#[IgnoreDeprecations]
#[Group('legacy')]
public function testDeprecatedAliasWithCustomMessage()
{
$this->expectUserDeprecationMessage('Since foo/bar 1.0.0: foo b.');
Expand All @@ -831,7 +829,6 @@ public function testDeprecatedAliasWithCustomMessage()
}

#[IgnoreDeprecations]
#[Group('legacy')]
public function testTargettingADeprecatedAliasShouldTriggerDeprecation()
{
$this->expectUserDeprecationMessage('Since foo/bar 1.0.0: foo b.');
Expand Down