Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UPGRADE-7.4.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Config

* Deprecate accessing the internal scope of the loader in PHP config files, use only its public API instead
* Deprecate setting a default value to a node that is required, and vice versa
* Deprecate generating fluent methods in config builders
* Deprecate fluent config builders, return PHP arrays from your config instead

Console
-------
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ CHANGELOG
* Add support for union types with `Symfony\Component\EventDispatcher\Attribute\AsEventListener`
* Add `framework.allowed_http_method_override` option
* Initialize `router.request_context`'s `_locale` parameter to `%kernel.default_locale%`
* Deprecate `ConfigBuilderCacheWarmer`, return PHP arrays from your config instead

7.3
---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
*
* @final since Symfony 7.1
* @deprecated since Symfony 7.4
*/
class ConfigBuilderCacheWarmer implements CacheWarmerInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
use Symfony\Component\Cache\Marshaller\MarshallerInterface;
use Symfony\Component\Cache\ResettableInterface;
use Symfony\Component\Clock\ClockInterface;
use Symfony\Component\Config\Builder\ConfigBuilderGenerator;
use Symfony\Component\Config\Definition\ConfigurationInterface;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\Config\Loader\LoaderInterface;
Expand Down Expand Up @@ -297,6 +298,9 @@ public function load(array $configs, ContainerBuilder $container): void
if (!class_exists(IsSignatureValidAttributeListener::class)) {
$container->removeDefinition('controller.is_signature_valid_attribute_listener');
}
if (!class_exists(ConfigBuilderGenerator::class)) {
$container->removeDefinition('config_builder.warmer');
}

if ($this->hasConsole()) {
$loader->load('console.php');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

namespace Symfony\Bundle\FrameworkBundle\Tests\CacheWarmer;

use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use Symfony\Bundle\FrameworkBundle\CacheWarmer\ConfigBuilderCacheWarmer;
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
use Symfony\Bundle\FrameworkBundle\Tests\TestCase;
Expand All @@ -31,7 +33,9 @@
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\HttpKernel\KernelInterface;

class ConfigBuilderCacheWarmerTest extends TestCase
#[IgnoreDeprecations]
#[Group('legacy')]
final class ConfigBuilderCacheWarmerTest extends TestCase
{
private string $varDir;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
* Generate ConfigBuilders to help create valid config.
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
*
* @deprecated since Symfony 7.4
*/
class ConfigBuilderGenerator implements ConfigBuilderGeneratorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
* Generates ConfigBuilders to help create valid config.
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
*
* @deprecated since Symfony 7.4
*/
interface ConfigBuilderGeneratorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
* A ConfigBuilder provides helper methods to build a large complex array.
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
*
* @deprecated since Symfony 7.4
*/
interface ConfigBuilderInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Config/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ CHANGELOG
* Add array-shapes to generated config builders
* Deprecate accessing the internal scope of the loader in PHP config files, use only its public API instead
* Deprecate setting a default value to a node that is required, and vice versa
* Deprecate generating fluent methods in config builders
* Deprecate fluent config builders, return PHP arrays from your config instead

7.3
---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,13 @@

namespace Symfony\Component\Config\Tests\Builder;

use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Config\Builder\ClassBuilder;
use Symfony\Component\Config\Builder\ConfigBuilderGenerator;
use Symfony\Component\Config\Builder\ConfigBuilderInterface;
use Symfony\Component\Config\Builder\Method;
use Symfony\Component\Config\Builder\Property;
use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
use Symfony\Component\Config\Tests\Builder\Fixtures\AddToList;
use Symfony\Component\Config\Tests\Builder\Fixtures\NodeInitialValues;
Expand All @@ -35,10 +32,8 @@
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
*/
#[CoversClass(ClassBuilder::class)]
#[CoversClass(ConfigBuilderGenerator::class)]
#[CoversClass(Method::class)]
#[CoversClass(Property::class)]
#[IgnoreDeprecations]
#[Group('legacy')]
class GeneratedConfigTest extends TestCase
{
private array $tempDir = [];
Expand Down
Loading