[Form] Fix DateType handling of julian calendar dates
#62126
Conversation
MatTheCat
force-pushed
the
ticket_31057
branch
from
0e00100 to
0d81a4f
Compare
| if (isset($options['calendar'])) { | ||
| $calendar = $options['calendar']; | ||
| } else { | ||
| $calendar = new \IntlGregorianCalendar(); |
There was a problem hiding this comment.
this adds a strict dependency to ext-intl for the default configuration because symfony/polyfill-intl-icu does not provide a polyfill for IntlGregorianCalendar
There was a problem hiding this comment.
btw, this also changes the existing behavior for forms for the default setup, which might cause other issues. Maybe you should instead solve your case by configuring a calendar option (either explicitly when using the DateType or project-wide by registering a FormTypeExtension replacing the default value of the calendar option)
|
Better fixed in the documentation |
|
Another thing to be careful: when passing a calendar object (instead of one of the numeric constants), |
3 participants
From #29610 (comment) and https://stackoverflow.com/q/71779588; I guess this wasn’t fixed before because it needed #57960 (which is why this PR targets 7.3).