Skip to content

[Messenger] Simplify code #62110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Oct 20, 2025
Merged

[Messenger] Simplify code #62110

nicolas-grekas merged 1 commit into from
Oct 20, 2025

Conversation

@HypeMC
Copy link
Member

@HypeMC HypeMC commented Oct 19, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Noticed while working on #61843.

There's no reason for the event to be dispatched inside the loop anymore:

  1. The event was originally dispatched outside the loop.
  2. It was later moved inside the loop because of the retry mechanism.
  3. The retry mechanism was later extracted, so there's no longer a need for the event to be dispatched inside the loop.

@carsonbot carsonbot added this to the 7.4 milestone Oct 19, 2025
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 20, 2025

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit bcb1ba5 into symfony:7.4 Oct 20, 2025
10 of 12 checks passed
@HypeMC HypeMC deleted the messenger-simplify-code branch October 20, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Messenger Status: Needs Review

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

3 participants

@HypeMC @nicolas-grekas @carsonbot