Skip to content

[Serializer] Fix unexpected type in denormalization errors when float|int union type used in constructor with non numeric string in form-data request #62003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Oct 8, 2025
+20 −0
Merged

[Serializer] Fix unexpected type in denormalization errors when float|int union type used in constructor with non numeric string in form-data request #62003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,8 @@ private function validateAndDenormalize(array $types, string $currentClass, stri
if (!$isUnionType && !$isNullable) {
throw $e;
}

$expectedTypes[Type::BUILTIN_TYPE_OBJECT === $builtinType && $class ? $class : $builtinType] = true;
} catch (ExtraAttributesException $e) {
if (!$isUnionType && !$isNullable) {
throw $e;
Expand Down
18 changes: 18 additions & 0 deletions src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
use Symfony\Component\PropertyInfo\PropertyInfoExtractor;
use Symfony\Component\Serializer\Attribute\Ignore;
use Symfony\Component\Serializer\Exception\LogicException;
use Symfony\Component\Serializer\Exception\NotNormalizableValueException;
use Symfony\Component\Serializer\Exception\RuntimeException;
use Symfony\Component\Serializer\Exception\UnexpectedValueException;
use Symfony\Component\Serializer\Mapping\ClassDiscriminatorFromClassMetadata;
Expand All @@ -41,6 +42,7 @@
use Symfony\Component\Serializer\Tests\Fixtures\Attributes\GroupDummy;
use Symfony\Component\Serializer\Tests\Fixtures\CircularReferenceDummy;
use Symfony\Component\Serializer\Tests\Fixtures\DummyPrivatePropertyWithoutGetter;
use Symfony\Component\Serializer\Tests\Fixtures\DummyWithUnion;
use Symfony\Component\Serializer\Tests\Fixtures\FormatAndContextAwareNormalizer;
use Symfony\Component\Serializer\Tests\Fixtures\OtherSerializedNameDummy;
use Symfony\Component\Serializer\Tests\Fixtures\Php74Dummy;
Expand Down Expand Up @@ -343,6 +345,22 @@ public function testConstructorWithUnknownObjectTypeHintDenormalize()
$normalizer->denormalize($data, DummyWithConstructorInexistingObject::class);
}

public function testConstructorWithNotMatchingUnionTypes()
{
$data = [
'value' => 'string',
'value2' => 'string',
];
$normalizer = new ObjectNormalizer(new ClassMetadataFactory(new AttributeLoader()), null, null, new PropertyInfoExtractor([], [new ReflectionExtractor()]));

$this->expectException(NotNormalizableValueException::class);
$this->expectExceptionMessage('The type of the "value" attribute for class "Symfony\Component\Serializer\Tests\Fixtures\DummyWithUnion" must be one of "int", "float" ("string" given).');

$normalizer->denormalize($data, DummyWithUnion::class, 'xml', [
AbstractNormalizer::ALLOW_EXTRA_ATTRIBUTES => false,
]);
}

// attributes

protected function getNormalizerForAttributes(): ObjectNormalizer
Expand Down
Loading