[TypeInfo] ArrayShape can resolve key type as callable instead of string #61943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.3". Cheers! Carsonbot |
Dean151
force-pushed
the
callable-array-shape-key
branch
from
025c55b to
5f11c35
Compare
stof
reviewed
Oct 3, 2025
Dean151
force-pushed
the
callable-array-shape-key
branch
from
5f11c35 to
7dd5b1a
Compare
GromNaN
reviewed
Oct 3, 2025
Dean151
force-pushed
the
callable-array-shape-key
branch
from
7dd5b1a to
85575db
Compare
In PHP, array key type is either string or int. Although callable is not entirely false as long as it's a string callable, using callable as a key type for an array seems wrong, and it's unlikely to be what we expect. This is peculiarly true in environment when key name might collide with global function name. Proposed change is to check for int/string instead of resolving type. Because the input is an array, the key is already narrowed down to string|int in the input This bugfix is also a change of behavior, as callable was likely to be fed in keyTypes, and it won't longer occur with that change.
Dean151
force-pushed
the
callable-array-shape-key
branch
from
85575db to
5b9d547
Compare
GromNaN
approved these changes
Oct 3, 2025
Contributor
Author
Yeah, the kind of thing you run into when you get a weird problem! Can someone fix the milestone? It was wrongly assigned to 7.4 instead of 7.3, because I messed up the PR opening ^^' Thanks! |
stof
approved these changes
Oct 3, 2025
fabpot
approved these changes
Oct 4, 2025
Member
|
Thank you @Dean151. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP, array key type is either string or int. Although callable is not entirely false as long as it's a string callable, using callable as a key type for an array seems wrong, and it's unlikely to be what we expect. This is peculiarly true in environment when key name might collide with global function name.
Proposed change is to check for int/string instead of resolving type.
Because the input is an array, the key is already narrowed down to string|int in the input
This bugfix is also a change of behavior, as callable was likely to be fed in keyTypes, and it won't longer occur with that change.