[Messenger] Allow to respect retry strategy with RecoverableMessageHandlingException #61936
+48
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
forceRetry
branch
2 times, most recently
from
4fd9606 to
c8be16f
Compare
src/Symfony/Component/Messenger/Exception/RecoverableExceptionInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Exception/RecoverableMessageHandlingException.php
Outdated
Show resolved
Hide resolved
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
the changelog and upgrade files should mention the new method
VincentLanglet
force-pushed
the
forceRetry
branch
from
f18a81c to
9559f73
Compare
Contributor
Author
|
Thanks for the review @nicolas-grekas ; I updated the PR. Failure seems unrelated since they are redis-related |
VincentLanglet
force-pushed
the
forceRetry
branch
from
9559f73 to
9beab3a
Compare
Contributor
Author
|
Friendly ping @nicolas-grekas for a small review :) This was tagged as |
VincentLanglet
force-pushed
the
forceRetry
branch
from
9beab3a to
1dd27a9
Compare
VincentLanglet
force-pushed
the
forceRetry
branch
from
1dd27a9 to
b2185b2
Compare
VincentLanglet
force-pushed
the
forceRetry
branch
from
b2185b2 to
3274e58
Compare
Contributor
Author
|
I rebased, ready for a new review @nicolas-grekas :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
getRetryDelaywas added, theRecoverableMessageHandlingExceptionis useful to override the defaut delay of the retry strategy (for instance if we get rate limited by some thing and would like to retry after some delay). BUT this imply the message will be retried again and again if we keep getting such error.#49063 asked RecoverableMessageHandlingException to respect the retryStrategy and #50655 revert it because if
RecoverableMessageHandlingExceptionrespect the retry strategy it has no use. Now I think this feature would be useful, as an option: