Skip to content

Conversation

@kochen
Copy link
Contributor

@kochen kochen commented Oct 2, 2025

As discussed in profiler should not be forced in order to make use of mailer assertions.
This reverts commit b63317d.

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #61873
License MIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Revert "[Mailer] Fix memory leak with mailer.message_logger_listener" [Mailer] Revert " Fix memory leak with mailer.message_logger_listener" Oct 2, 2025
@kochen kochen changed the base branch from 7.4 to 7.3 October 2, 2025 09:34
@chalasr chalasr modified the milestones: 7.4, 7.3 Oct 3, 2025
@fabpot
Copy link
Member

fabpot commented Oct 4, 2025

Thank you @kochen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A client must have Mailer enabled to make email assertions.

5 participants