Skip to content

[Intl] Support time in generated data in currencies validity #61859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
Oct 1, 2025
Merged

[Intl] Support time in generated data in currencies validity #61859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/Symfony/Component/Intl/Data/Generator/CurrencyDataGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,11 @@ private function generateCurrencyMap(mixed $supplementalDataBundle): array
}

if (\array_key_exists('from', $metadata)) {
$metadata['from'] = self::icuPairToDate($metadata['from']);
$metadata['from'] = self::icuPairToDatetimeString($metadata['from']);
}

if (\array_key_exists('to', $metadata)) {
$metadata['to'] = self::icuPairToDate($metadata['to']);
$metadata['to'] = self::icuPairToDatetimeString($metadata['to']);
}

if (\array_key_exists('tender', $metadata)) {
Expand Down Expand Up @@ -229,7 +229,7 @@ private function generateNumericToAlpha3Mapping(array $alpha3ToNumericMapping):
*
* @param array{0: int, 1: int} $pair
*/
private static function icuPairToDate(array $pair): string
private static function icuPairToDatetimeString(array $pair): string
{
[$highBits32, $lowBits32] = $pair;

Expand All @@ -245,12 +245,13 @@ private static function icuPairToDate(array $pair): string
--$seconds;
}

$datetime = \DateTimeImmutable::createFromFormat('U', $seconds, new \DateTimeZone('Etc/UTC'));
// Note: Unlike the XML files, the date pair is already in UTC.
$datetime = \DateTimeImmutable::createFromFormat('U', (string) $seconds, new \DateTimeZone('Etc/UTC'));

if (false === $datetime) {
throw new \RuntimeException('Unable to parse ICU milliseconds pair.');
}

return $datetime->format('Y-m-d');
return $datetime->format('Y-m-d\TH:i:s');
}
}
Loading
Loading