Skip to content

do not coerce NAN to other types #61844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Sep 25, 2025
Merged

do not coerce NAN to other types #61844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/ConstraintValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ protected function formatValue(mixed $value, int $format = 0): string
return 'true';
}

if (is_nan($value)) {
return 'NAN';
}

return (string) $value;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/VarDumper/Cloner/Data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ private function dumpItem(DumperInterface $dumper, Cursor $cursor, array &$refs,
if (!$item instanceof Stub) {
$cursor->attr = [];
$type = \gettype($item);
if ($item && 'array' === $type) {
if ('array' === $type && $item) {
Copy link
Member Author

@xabbuh xabbuh Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably not the only place where coercing NAN to bool can bite us, but it's the only placed caught by our test suite

$item = $this->getStub($item);
}
} elseif (Stub::TYPE_REF === $item->type) {
Expand Down
Loading