Skip to content

[Validator] deprecate passing an associative array to GroupSequence #61841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
Sep 26, 2025
Merged

[Validator] deprecate passing an associative array to GroupSequence #61841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions UPGRADE-7.4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,19 @@ Uid
Validator
---------

* Deprecate handling associative arrays in `GroupSequence`

*Before*

```php
$groupSequence = GroupSequence(['value' => ['group 1', 'group 2']]);
```

*After*

```php
$groupSequence = GroupSequence(['group 1', 'group 2']);
```
* Deprecate configuring constraint options implicitly with the XML format

*Before*
Expand Down
13 changes: 13 additions & 0 deletions src/Symfony/Component/Validator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,19 @@ CHANGELOG
7.4
---

* Deprecate handling associative arrays in `GroupSequence`

Before:

```php
$groupSequence = GroupSequence(['value' => ['group 1', 'group 2']]);
```

After:

```php
$groupSequence = GroupSequence(['group 1', 'group 2']);
```
* Deprecate configuring constraint options implicitly with the XML format

Before:
Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Constraints/GroupSequence.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ class GroupSequence
#[HasNamedArguments]
public function __construct(array $groups)
{
if (!array_is_list($groups)) {
trigger_deprecation('symfony/validator', '7.4', 'Support for passing an array of options to "%s()" is deprecated.', __METHOD__);
}

$this->groups = $groups['value'] ?? $groups;
}
}
6 changes: 6 additions & 0 deletions src/Symfony/Component/Validator/Tests/Constraints/GroupSequenceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

namespace Symfony\Component\Validator\Tests\Constraints;

use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Validator\Constraints\GroupSequence;

Expand All @@ -26,8 +28,12 @@ public function testCreate()
$this->assertSame(['Group 1', 'Group 2'], $sequence->groups);
}

#[Group('legacy')]
#[IgnoreDeprecations]
public function testCreateDoctrineStyle()
{
$this->expectUserDeprecationMessage('Since symfony/validator 7.4: Support for passing an array of options to "Symfony\Component\Validator\Constraints\GroupSequence::__construct()" is deprecated.');

$sequence = new GroupSequence(['value' => ['Group 1', 'Group 2']]);

$this->assertSame(['Group 1', 'Group 2'], $sequence->groups);
Expand Down
Loading