[JsonPath] Add Nothing enum to support special nothing value
#61749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
stof
approved these changes
Sep 15, 2025
Member
|
Thank you @alexandre-daubois. |
GromNaN
reviewed
Nov 1, 2025
|
|
||
| namespace Symfony\Component\JsonPath; | ||
|
|
||
| enum Nothing |
Member
Author
There was a problem hiding this comment.
No, it is needed by custom functions: people should be able to return this special Nothing value to be correctly handled by the component when necessary (PR to be merged, but we added it in prevision)
nicolas-grekas
added a commit
that referenced
this pull request
Nov 3, 2025
…wler (yoeunes) This PR was merged into the 7.4 branch. Discussion ---------- [JsonPath] Remove unused "nothing" property from JsonCrawler | Q | A |---|--- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | n/a | License | MIT This PR removes the `private static \stdClass $nothing;` property from `JsonCrawler`, as it is no longer used and has been replaced by the `Nothing::Nothing` enum. See #61749 Commits ------- 436ab11 [JsonPath] Remove unused "nothing" property from JsonCrawler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61517 introduces custom functions mechanism. For consistency, RFC built-in functions will also use the new functions mechanism. In order to fully work, functions must be able to return the special
nothingvalue defined by the RFC. This PR exposes the Nothing enum to the public API instead of storing it internally in the JsonCrawler with stdClass.Context: #61517 (comment)