Skip to content

[PhpUnitBridge] Fix gathering deprecation in phpt #61731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Sep 11, 2025
Merged

[PhpUnitBridge] Fix gathering deprecation in phpt #61731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
use PHPUnit\Framework\TestCase;
use PHPUnit\Framework\TestSuite;
use PHPUnit\Runner\BaseTestRunner;
use PHPUnit\Runner\PhptTestCase;
use PHPUnit\Util\Blacklist;
use PHPUnit\Util\ExcludeList;
use PHPUnit\Util\Test;
Expand Down Expand Up @@ -206,6 +207,12 @@

public function startTest($test): void
{
if (-2 < $this->state && $test instanceof PhptTestCase) {
$this->runsInSeparateProcess = tempnam(sys_get_temp_dir(), 'deprec');
putenv('SYMFONY_DEPRECATIONS_SERIALIZE='.$this->runsInSeparateProcess);
putenv('SYMFONY_EXPECTED_DEPRECATIONS_SERIALIZE='.tempnam(sys_get_temp_dir(), 'expectdeprec'));
}

if (-2 < $this->state && $test instanceof TestCase) {
// This event is triggered before the test is re-run in isolation
if ($this->willBeIsolated($test)) {
Expand All @@ -218,7 +225,7 @@

if (!$this->runsInSeparateProcess) {
if (\in_array('time-sensitive', $groups, true)) {
ClockMock::register(\get_class($test));

Check failure on line 228 in src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php

View workflow job for this annotation

GitHub Actions / Psalm

UndefinedClass 

src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php:228:21: UndefinedClass: Class, interface or enum named Symfony\Bridge\PhpUnit\ClockMock does not exist (see https://psalm.dev/019)

Check failure on line 228 in src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php

View workflow job for this annotation

GitHub Actions / Psalm

UndefinedClass 

src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php:228:21: UndefinedClass: Class, interface or enum named Symfony\Bridge\PhpUnit\ClockMock does not exist (see https://psalm.dev/019)
ClockMock::withClockMock(true);
}
if (\in_array('dns-sensitive', $groups, true)) {
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/String/Tests/LazyStringTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
namespace Symfony\Component\String\Tests;

use PHPUnit\Framework\TestCase;
use Symfony\Component\ErrorHandler\ErrorHandler;
use Symfony\Component\String\LazyString;

class LazyStringTest extends TestCase
Expand All @@ -34,8 +33,6 @@ public function testLazyString()
*/
public function testReturnTypeError()
{
ErrorHandler::register();

$s = LazyString::fromCallable(fn () => []);

$this->expectException(\TypeError::class);
Expand Down
3 changes: 1 addition & 2 deletions src/Symfony/Component/String/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@
"symfony/polyfill-mbstring": "~1.0"
},
"require-dev": {
"symfony/error-handler": "^5.4|^6.0|^7.0",
"symfony/intl": "^6.2|^7.0",
"symfony/http-client": "^5.4|^6.0|^7.0",
"symfony/intl": "^6.2|^7.0",
"symfony/translation-contracts": "^2.5|^3.0",
"symfony/var-exporter": "^5.4|^6.0|^7.0"
},
Expand Down
Loading