Skip to content

[Console] Fixing expected error messages for missing inputs #61666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mamazu wants to merge 2 commits into from
Closed

[Console] Fixing expected error messages for missing inputs #61666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0d3b76
Fixing expected error messages
mamazu Sep 6, 2025
0a8f1cd
Making all error messages in the question helper better
mamazu Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Symfony/Component/Console/Helper/QuestionHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private function doAsk($inputStream, OutputInterface $output, Question $question
}

if (false === $ret) {
throw new MissingInputException('Aborted.');
throw new MissingInputException('Aborted. Unable to read input of question: '.$question->getQuestion());
}
if ($question->isTrimmable()) {
$ret = trim($ret);
Expand Down Expand Up @@ -271,7 +271,7 @@ private function autocomplete(OutputInterface $output, Question $question, $inpu
// as opposed to fgets(), fread() returns an empty string when the stream content is empty, not false.
if (false === $c || ('' === $ret && '' === $c && null === $question->getDefault())) {
shell_exec('stty '.$sttyMode);
throw new MissingInputException('Aborted while asking: '.$question->getQuestion());
throw new MissingInputException('Aborted. Trying to autocomplete: '.$question->getQuestion());
} elseif ("\177" === $c) { // Backspace Character
if (0 === $numMatches && 0 !== $i) {
--$i;
Expand Down Expand Up @@ -443,7 +443,7 @@ private function getHiddenResponse(OutputInterface $output, $inputStream, bool $
}

if (false === $value) {
throw new MissingInputException('Aborted.');
throw new MissingInputException('Aborted. Unable to read hidden input.');
}
if ($trimmable) {
$value = trim($value);
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ public function testAskThrowsExceptionOnMissingInput()
public function testAskThrowsExceptionOnMissingInputForChoiceQuestion()
{
$this->expectException(MissingInputException::class);
$this->expectExceptionMessage('Aborted while asking: Choice');
$this->expectExceptionMessage('Aborted. Trying to autocomplete: Choice');
(new QuestionHelper())->ask($this->createStreamableInputInterfaceMock($this->getInputStream('')), $this->createOutputInterface(), new ChoiceQuestion('Choice', ['a', 'b']));
}

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Tests/Tester/CommandTesterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ public function testCommandWithQuestionsButNoInputs()
$tester = new CommandTester($command);

$this->expectException(\RuntimeException::class);
$this->expectExceptionMessage('Aborted.');
$this->expectExceptionMessage('Aborted. Unable to read input of question: choice');

$tester->execute([]);
}
Expand Down
Loading