[Security] Fix HttpUtils::createRequest() when the base request is forwarded
#61659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you @MatTheCat. |
|
Hi @MatTheCat , It seems that there is still an issue when we try to create a request from a route name, not a path: // In your test, use path to create the request => OK
(new HttpUtils())->createRequest(Request::create('/', server: ['HTTP_X_FORWARDED_PREFIX' => '/foo']), '/')->getUri(),
// Using route name to create the request => KO
(new HttpUtils())->createRequest(Request::create('/', server: ['HTTP_X_FORWARDED_PREFIX' => '/foo']), 'my_route')->getUri(), |
Contributor
Author
|
Hey @kira0269 your example doesn’t mention what the problem is and I’m not able to see any. You can open a new issue if you noticed something is wrong. |
Contributor
Author
|
Okay was able to reproduce: the URL generator context should also be updated. Will open a PR; no need for an issue. Thanks! |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2025
…xt’s base URL isn’t empty (MatTheCat) This PR was merged into the 6.4 branch. Discussion ---------- [Security] Fix `HttpUtils::createRequest()` when the context’s base URL isn’t empty | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #61659 (comment) | License | MIT Commits ------- 3210543 [Security] Fix `HttpUtils::createRequest()` when the context’s base URL isn’t empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently trusted headers are both copied from the original request and used to generate the URI. That means if we have a trusted
/fooprefix the URI generated for/barwould be/foo/bar, and the new request URI would be/foo/foo/bar.This PR temporarily distrusts proxies so that the generated URI would be
/bar, and the new request URI/foo/bar.