[Cache] Fix internal representation of non-static values #61605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
cache-value
branch
from
d5ca6c9 to
a5823af
Compare
Contributor
|
After upgrading symfony/cache from v6.4.24 to v6.4.26, all my API automation tests started to fail. I didn't look very deep yet, but was surprised that a patch version upgrade would break it. |
Member
Author
|
See #61868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a PR to allow exporting named closures, and the way we use closures in PhpArrayAdapter and PhpFilesAdapter gets into my way.
Instead of relying on
instanceof \Closurechecks, this PR adds an internal marker interface. This makes the logic specific to the component, enabling having closures as regular cached values.The new logic is tested since adapters are.