Skip to content

[Validator] require a top-level domain by default in the Url constraint #61540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Aug 27, 2025
Merged

[Validator] require a top-level domain by default in the Url constraint #61540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UPGRADE-8.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,7 @@ Uid
Validator
---------

* Change the default value of the `$requireTld` option of the `Url` constraint to `true`
* Add method `getGroupProvider()` to `ClassMetadataInterface`
* Replace `__sleep/wakeup()` by `__(un)serialize()` on `GenericMetadata` implementations
* Remove the `getRequiredOptions()` and `getDefaultOption()` methods from the `All`, `AtLeastOneOf`, `CardScheme`, `Collection`,
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Validator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ CHANGELOG
8.0
---

* Change the default value of the `$requireTld` option of the `Url` constraint to `true`
* Add method `getGroupProvider()` to `ClassMetadataInterface`
* Replace `__sleep/wakeup()` by `__(un)serialize()` on `GenericMetadata` implementations
* Remove the `getRequiredOptions()` and `getDefaultOption()` methods from the `All`, `AtLeastOneOf`, `CardScheme`, `Collection`,
Expand Down
6 changes: 1 addition & 5 deletions src/Symfony/Component/Validator/Constraints/Url.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class Url extends Constraint
public string $tldMessage = 'This URL is missing a top-level domain.';
public array $protocols = ['http', 'https'];
public bool $relativeProtocol = false;
public bool $requireTld = false;
public bool $requireTld = true;
/** @var callable|null */
public $normalizer;

Expand All @@ -61,10 +61,6 @@ public function __construct(

parent::__construct(null, $groups, $payload);

if (null === $requireTld) {
trigger_deprecation('symfony/validator', '7.1', 'Not passing a value for the "requireTld" option to the Url constraint is deprecated. Its default value will change to "true".');
}

$this->message = $message ?? $this->message;
$this->protocols = $protocols ?? $this->protocols;
$this->relativeProtocol = $relativeProtocol ?? $this->relativeProtocol;
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/Validator/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
],
"require": {
"php": ">=8.4",
"symfony/deprecation-contracts": "^2.5|^3",
Copy link
Contributor

@ro0NL ro0NL Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can keep the package installed forever

"symfony/polyfill-ctype": "^1.8",
"symfony/polyfill-mbstring": "^1.0",
"symfony/translation-contracts": "^2.5|^3"
Expand Down
Loading