Skip to content

[Routing][Serializer] Remove annotation aliases and getters and setters in favor of public properties on attributes #61488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Aug 21, 2025
Merged

[Routing][Serializer] Remove annotation aliases and getters and setters in favor of public properties on attributes #61488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion UPGRADE-8.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,8 @@ Routing

* Providing a non-array `_query` parameter to `UrlGenerator` causes an `InvalidParameterException`
* Remove the protected `AttributeClassLoader::$routeAnnotationClass` property and the `setRouteAnnotationClass()` method, use `AttributeClassLoader::setRouteAttributeClass()` instead
* Remove `getEnv()` and `setEnv()` methods of the `Route` attribute; use the plurialized `getEnvs()` and `setEnvs()` methods instead
* Remove class aliases in the `Annotation` namespace, use attributes instead
* Remove getters and setters in attribute classes in favor of public properties

Security
--------
Expand Down Expand Up @@ -462,6 +463,8 @@ Serializer
```
* Remove `AdvancedNameConverterInterface`, use `NameConverterInterface` instead
* Remove the `CompiledClassMetadataFactory` and `CompiledClassMetadataCacheWarmer` classes
* Remove class aliases in the `Annotation` namespace, use attributes instead
* Remove getters in attribute classes in favor of public properties

Translation
-----------
Expand Down
26 changes: 0 additions & 26 deletions src/Symfony/Component/Routing/Annotation/Route.php
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions src/Symfony/Component/Routing/Attribute/DeprecatedAlias.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,28 +23,4 @@ public function __construct(
public readonly string $message = '',
) {
}

#[\Deprecated('Use the "message" property instead', 'symfony/routing:7.4')]
public function getMessage(): string
{
return $this->message;
}

#[\Deprecated('Use the "aliasName" property instead', 'symfony/routing:7.4')]
public function getAliasName(): string
{
return $this->aliasName;
}

#[\Deprecated('Use the "package" property instead', 'symfony/routing:7.4')]
public function getPackage(): string
{
return $this->package;
}

#[\Deprecated('Use the "version" property instead', 'symfony/routing:7.4')]
public function getVersion(): string
{
return $this->version;
}
}
173 changes: 0 additions & 173 deletions src/Symfony/Component/Routing/Attribute/Route.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,177 +88,4 @@ public function __construct(
$this->defaults['_stateless'] = $stateless;
}
}

#[\Deprecated('Use the "path" property instead', 'symfony/routing:7.4')]
public function setPath(string $path): void
{
$this->path = $path;
}

#[\Deprecated('Use the "path" property instead', 'symfony/routing:7.4')]
public function getPath(): ?string
{
return \is_array($this->path) ? null : $this->path;
}

#[\Deprecated('Use the "path" property instead', 'symfony/routing:7.4')]
public function setLocalizedPaths(array $localizedPaths): void
{
$this->path = $localizedPaths;
}

#[\Deprecated('Use the "path" property instead', 'symfony/routing:7.4')]
public function getLocalizedPaths(): array
{
return \is_array($this->path) ? $this->path : [];
}

#[\Deprecated('Use the "host" property instead', 'symfony/routing:7.4')]
public function setHost(string $pattern): void
{
$this->host = $pattern;
}

#[\Deprecated('Use the "host" property instead', 'symfony/routing:7.4')]
public function getHost(): ?string
{
return $this->host;
}

#[\Deprecated('Use the "name" property instead', 'symfony/routing:7.4')]
public function setName(string $name): void
{
$this->name = $name;
}

#[\Deprecated('Use the "name" property instead', 'symfony/routing:7.4')]
public function getName(): ?string
{
return $this->name;
}

#[\Deprecated('Use the "requirements" property instead', 'symfony/routing:7.4')]
public function setRequirements(array $requirements): void
{
$this->requirements = $requirements;
}

#[\Deprecated('Use the "requirements" property instead', 'symfony/routing:7.4')]
public function getRequirements(): array
{
return $this->requirements;
}

#[\Deprecated('Use the "options" property instead', 'symfony/routing:7.4')]
public function setOptions(array $options): void
{
$this->options = $options;
}

#[\Deprecated('Use the "options" property instead', 'symfony/routing:7.4')]
public function getOptions(): array
{
return $this->options;
}

#[\Deprecated('Use the "defaults" property instead', 'symfony/routing:7.4')]
public function setDefaults(array $defaults): void
{
$this->defaults = $defaults;
}

#[\Deprecated('Use the "defaults" property instead', 'symfony/routing:7.4')]
public function getDefaults(): array
{
return $this->defaults;
}

#[\Deprecated('Use the "schemes" property instead', 'symfony/routing:7.4')]
public function setSchemes(array|string $schemes): void
{
$this->schemes = (array) $schemes;
}

#[\Deprecated('Use the "schemes" property instead', 'symfony/routing:7.4')]
public function getSchemes(): array
{
return $this->schemes;
}

#[\Deprecated('Use the "methods" property instead', 'symfony/routing:7.4')]
public function setMethods(array|string $methods): void
{
$this->methods = (array) $methods;
}

#[\Deprecated('Use the "methods" property instead', 'symfony/routing:7.4')]
public function getMethods(): array
{
return $this->methods;
}

#[\Deprecated('Use the "condition" property instead', 'symfony/routing:7.4')]
public function setCondition(?string $condition): void
{
$this->condition = $condition;
}

#[\Deprecated('Use the "condition" property instead', 'symfony/routing:7.4')]
public function getCondition(): ?string
{
return $this->condition;
}

#[\Deprecated('Use the "priority" property instead', 'symfony/routing:7.4')]
public function setPriority(int $priority): void
{
$this->priority = $priority;
}

#[\Deprecated('Use the "priority" property instead', 'symfony/routing:7.4')]
public function getPriority(): ?int
{
return $this->priority;
}

#[\Deprecated('Use the "envs" property instead', 'symfony/routing:7.4')]
public function setEnv(?string $env): void
{
$this->envs = (array) $env;
}

#[\Deprecated('Use the "envs" property instead', 'symfony/routing:7.4')]
public function getEnv(): ?string
{
if (!$this->envs) {
return null;
}
if (\count($this->envs) > 1) {
throw new LogicException(\sprintf('The "env" property has %d environments. Use "getEnvs()" to get all of them.', \count($this->envs)));
}

return $this->envs[0];
}

/**
* @return (string|DeprecatedAlias)[]
*/
#[\Deprecated('Use the "aliases" property instead', 'symfony/routing:7.4')]
public function getAliases(): array
{
return $this->aliases;
}

/**
* @param string|DeprecatedAlias|(string|DeprecatedAlias)[] $aliases
*/
#[\Deprecated('Use the "aliases" property instead', 'symfony/routing:7.4')]
public function setAliases(string|DeprecatedAlias|array $aliases): void
{
$this->aliases = \is_array($aliases) ? $aliases : [$aliases];
}
}

if (!class_exists(\Symfony\Component\Routing\Annotation\Route::class, false)) {
class_alias(Route::class, \Symfony\Component\Routing\Annotation\Route::class);
}
3 changes: 2 additions & 1 deletion src/Symfony/Component/Routing/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ CHANGELOG

* Providing a non-array `_query` parameter to `UrlGenerator` causes an `InvalidParameterException`
* Remove the protected `AttributeClassLoader::$routeAnnotationClass` property and the `setRouteAnnotationClass()` method, use `AttributeClassLoader::setRouteAttributeClass()` instead
* Remove `getEnv()` and `setEnv()` methods of the `Route` attribute; use the plurialized `getEnvs()` and `setEnvs()` methods instead
* Remove class aliases in the `Annotation` namespace, use attributes instead
* Remove getters and setters in attribute classes in favor of public properties

7.4
---
Expand Down
2 changes: 1 addition & 1 deletion ...ymfony/Component/Routing/Tests/Fixtures/AttributeFixtures/RouteWithPriorityController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures;

use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Routing\Attribute\Route;

class RouteWithPriorityController
{
Expand Down
26 changes: 0 additions & 26 deletions src/Symfony/Component/Serializer/Annotation/Context.php
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions src/Symfony/Component/Serializer/Annotation/DiscriminatorMap.php
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions src/Symfony/Component/Serializer/Annotation/Groups.php
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions src/Symfony/Component/Serializer/Annotation/Ignore.php
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions src/Symfony/Component/Serializer/Annotation/MaxDepth.php
View file
Open in desktop

This file was deleted.

Loading
Loading