[Intl] Take timezoneTypes’ ianaMap into account #61426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
i'd do the icu update first yes for this PR it will also impact the timezone form type, but i dont think it matters much |
MatTheCat
force-pushed
the
ticket_61289
branch
from
7052d36 to
03d78ca
Compare
Contributor
Author
|
My mistake, data were updated by #60157; I needed to order the test’s zones and update the timezone <=> country mapping. Should be good now. |
MatTheCat
force-pushed
the
ticket_61289
branch
from
03d78ca to
61b8765
Compare
nicolas-grekas
approved these changes
Aug 19, 2025
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
I'm just wondering: shouldn't we merge this to 6.4?
Member
|
Given that we update the ICU data in the LTS version, fixes to the data generator should indeed be merged in 6.4, otherwise the next update will still use the old data generator (until the EOL of 6.4) |
nicolas-grekas
requested review from
chalasr,
dunglas,
lyrixx,
xabbuh and
yceruto
as code owners
nicolas-grekas
force-pushed
the
ticket_61289
branch
from
61b8765 to
3ed85ef
Compare
Member
|
Thank you @MatTheCat. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timezones name are CLDR canonical’s which “[are] based on very old version of the time zone database” (source). This means that IANA canonical timezones won’t appear if they changed, so this PR adds them.
EDIT: I see tests run against ICU 76.1; should I update everything to 77.1?