Skip to content

[Scheduler] Fix scheduler.task tag arguments optionality #61307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Aug 5, 2025
Merged

[Scheduler] Fix scheduler.task tag arguments optionality #61307

nicolas-grekas merged 1 commit into from
Aug 5, 2025

Conversation

@jan-pintr
Copy link
Contributor

@jan-pintr jan-pintr commented Aug 2, 2025

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

According to this comment there is a change in behaviour after #60741 which causes requiring specify arguments parameter when tagging scheduler.task manually. This pull request makes arguments parameter back optional.

$myService->tag('scheduler.task', [
    'trigger' => 'every',
    'frequency' => 15,
    'arguments' => null, // <- had to add this line to avoid a Warning: Undefined array key "arguments"
]);

@jan-pintr jan-pintr requested a review from kbond as a code owner August 2, 2025 18:33
@carsonbot carsonbot added this to the 7.3 milestone Aug 2, 2025
@jan-pintr jan-pintr mentioned this pull request Aug 2, 2025
Merged
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Aug 5, 2025

Thank you @jan-pintr.

@nicolas-grekas nicolas-grekas force-pushed the fix-sheduler-task-tag-arguments-optionality branch from d966e61 to ad08041 Compare August 5, 2025 09:22
@nicolas-grekas nicolas-grekas merged commit d46d595 into symfony:7.3 Aug 5, 2025
11 checks passed
@fabpot fabpot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xabbuh xabbuh xabbuh approved these changes

@kbond kbond Awaiting requested review from kbond kbond is a code owner

Assignees

No one assigned

Labels

Bug Scheduler Status: Reviewed

Projects

None yet

Milestone

7.3

Development

Successfully merging this pull request may close these issues.

4 participants

@jan-pintr @nicolas-grekas @xabbuh @carsonbot