[HttpFoundation] Add support for structured MIME suffix #61267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
force-pushed
the
features/hybrid-mime-format
branch
2 times, most recently
from
a7beaed to
89470ad
Compare
fabpot
requested changes
Aug 17, 2025
Spomky
force-pushed
the
features/hybrid-mime-format
branch
from
89470ad to
309a6b7
Compare
fabpot
approved these changes
Aug 18, 2025
Expanded the MIME type list in `Request::getMimeTypes()` to include mappings for YAML, WBXML, PDF, and CSV formats.
Spomky
force-pushed
the
features/hybrid-mime-format
branch
from
309a6b7 to
f2ba0b3
Compare
fabpot
approved these changes
Aug 20, 2025
Member
|
Thank you @Spomky. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 20, 2025
…MatTheCat) This PR was squashed before being merged into the 7.4 branch. Discussion ---------- [HttpFoundation] Don’t check suffix on empty MIME type | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT Fix tests from #61267 (remaining failures unrelated). Commits ------- 3816617 [HttpFoundation] Don’t check suffix on empty MIME type
Member
|
Adding the new argument to the |
Contributor
Author
Indeed it is not in line with |
Member
|
While at it, maybe turn the added private method into a constant? |
Spomky
added a commit
to Spomky/symfony
that referenced
this pull request
Aug 28, 2025
…tured suffix formats as constant
Contributor
Author
|
Hi, |
Spomky
added a commit
to Spomky/symfony
that referenced
this pull request
Aug 28, 2025
…tured suffix formats as constant
Spomky
added a commit
to Spomky/symfony
that referenced
this pull request
Aug 28, 2025
…tured suffix formats as constant
nicolas-grekas
added a commit
that referenced
this pull request
Aug 28, 2025
…tructured suffix formats as constant (Spomky) This PR was merged into the 7.4 branch. Discussion ---------- [HttpFoundation] Fix BC Break introduces in `#61267` and structured suffix formats as constant | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no <!-- if yes, also update src/**/CHANGELOG.md --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Issues | Fix #... <!-- prefix each issue number with "Fix #"; no need to create an issue if none exists, explain below --> | License | MIT <!-- 🛠️ Replace this text with a concise explanation of your change: - What it does and why it's needed - A simple example of how it works (include PHP, YAML, etc.) - If it modifies existing behavior, include a before/after comparison Contributor guidelines: - ✅ Add tests and ensure they pass - 🐞 Bug fixes must target the **lowest maintained** branch where they apply https://symfony.com/releases#maintained-symfony-branches - ✨ New features and deprecations must target the **feature** branch and must add an entry to the changelog file of the patched component: https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - 🔒 Do not break backward compatibility: https://symfony.com/bc --> Commits ------- aec348d [HttpFoundation] Fix BC Break introduces in `#61267` and structured suffix formats as constant
This was referenced Oct 27, 2025
Merged
Merged
This was referenced Oct 30, 2025
nicolas-grekas
added a commit
that referenced
this pull request
Nov 1, 2025
…edefined formats (longwave) This PR was merged into the 6.4 branch. Discussion ---------- [HttpFoundation] Allow Request::setFormat() to override predefined formats | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62226 | License | MIT Since #61267 some additional MIME formats are predefined; in order to override the predefined formats you must explictly deregister them. This PR changes the order so formats added later take precedence. Commits ------- 2402d16 [HttpFoundation] Allow Request::setFormat() to override predefined formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended MIME type handling in
Request::getFormat()to support structured suffixes likeapplication/soap+xml. Introduced a private method to define fallback formats based on RFC specifications. Updated the test suite accordingly.It adds supports for common mime types:
soap: application/soap+xml (instead ofxml)problem: application/problem+jsonhal: application/hal+json, application/hal+xmljsonapi: application/vnd.api+jsonyaml: text/yaml, application/x-yamlwbxml: application/vnd.wap.wbxmlpdf: application/pdfcsv: text/csv